[#974] Add component edit window tab remembrance #1444
Conversation
|
I'm wondering though: should a user be able to disable this new behavior in the system preferences or do we want to make this default behavior? |
|
I would definitely make it the default behavior... hide it in preferences and no one will ever notice it. Those that are bothered by the new behavior might be motivated to go find the preference (or ask on the forum, or whatever). I think it's worth a checkbox in preferences. If it's easier to have the default options be disabled by default, or if it's too darn hard to come up with good wording for the option, then you can do it opposite: have the option be "Always open leftmost tab when opening a component edit dialog", unchecked by default. |
|
My preference would be to have the new behavior be the default behavior. |
|
Latest commits add option in preference panel (couldn't find a good enabled wording, so I went for the disabled wording proposed by Neil) |
|
Typo in tooltip: almost -> always |
|
I would change "leftmost" to "General", ditto on @neilweinstock. Otherwise, works beautifully, no anomalied found. |
My bad, it was too late when I made that change |
I would not do this because it's not always General, for stages and boosters it's 'override' and 'separation' respectively. |
3 participants
This PR fixes #974: Moving from component to component, configuration tab selected could open to the same tab.
The current behavior is this:
If a tab is selected the component config dialog of component 1, and you edit another component, component 2 (either by clicking component 2 while the edit dialog of component 1 is still open, or by first closing component 1's edit dialog, and then editing component 2):
If the previously selected tab of component 1 is also present for component 2 (e.g. both components have a ‘General’ tab or ‘Appearance’ tab), then that same tab is opened for component 2
If component 2 does not have the tab of component 1, the first tab of component 2 is selected (e.g. component 1 is a FinSet with the ‘Fin tabs’ tab selected, component 2 is a Body Tube, then the first tab of component 2 - ‘General’ - will be opened)
If a new component is added, the automatic dialog pop-up will always be opened in the first tab (e.g. ‘General’)
Demo:
Screen.Recording.2022-06-13.at.12.47.00.mp4