[#1231] Include non-aerodynamic components in bounding box calculations #1417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some parts of the program need only the bounding box of aerodynamic parts (most parts of the program), but a couple others need the bounding box and length of all components
Collaborator
|
Functions beautifully, no anomalies found as to this issue... but see Issue #1420. [Windows 11 Pro, Version 21H2, OS Build 22000.675, Windows Feature Experience Pack 1000.22000.675.0] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1231 by including non-aerodynamic components in the rocket's bounding box calculations.
I first just deleted the aerodynamic condition in the bounding box calculations, but most parts of the program (including some calculations) need the bounding box or rocket length of only aerodynamic components. Just deleting the aerodynamic condition caused changes in the calculations.
So I ended up splitting the bounding box and rocket length in two variations: only aerodynamic components and all components.
This PR not only fixes #1231, but now the rocket length displayed in the rocket view's top left corner includes all components, not only the length of the aerodynamic components.
Here is a jar file for testing.