Inline JavaParser and JavaTemplate fields in recipes#951
Merged
Conversation
Remove the legacy pattern of storing JavaParser.Builder and JavaTemplate instances as cached fields on visitors, inlining them at each usage site instead.
timtebeek
commented
Mar 31, 2026
Comment on lines
214
to
216
| private static JavaParser.Builder<?, ?> javaParser(ExecutionContext ctx) { | ||
| return JavaParser.fromJavaVersion() | ||
| .classpathFromResources(ctx, "junit-jupiter-api-5", "hamcrest-3", "junit-jupiter-params-5"); |
Member
Author
There was a problem hiding this comment.
Also inline this method.
timtebeek
commented
Mar 31, 2026
Comment on lines
186
to
188
| private static JavaParser.Builder<?, ?> javaParser(ExecutionContext ctx) { | ||
| return JavaParser.fromJavaVersion() | ||
| .classpathFromResources(ctx, "junit-jupiter-api-5", "junit-jupiter-params-5"); |
Member
Author
There was a problem hiding this comment.
Also inline this method.
Address PR feedback to fully inline the javaParser(ctx) helper methods in JUnitParamsRunnerToParameterized and ParameterizedRunnerToParameterized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
JavaParser.BuilderandJavaTemplateinstances as cached fields on visitors, inlining them at each usage site instead.JavaParser.Builderfields that are now inlined.RunnerToExtension,JUnitParamsRunnerToParameterized,ParameterizedRunnerToParameterized) had cachedJavaTemplatefields built in constructors or lazy-init methods, now replaced with inline construction.