Add AssertEqualsIntegralDeltaToAssertEquals recipe#950
Merged
Conversation
Remove the unnecessary delta/precision argument from assertEquals when both expected and actual are int or long types, since the delta is meaningless for exact integer comparison.
sullis
pushed a commit
to sullis/rewrite-testing-frameworks
that referenced
this pull request
Mar 31, 2026
* Add AssertEqualsIntegralDeltaToAssertEquals recipe (openrewrite#869) Remove the unnecessary delta/precision argument from assertEquals when both expected and actual are int or long types, since the delta is meaningless for exact integer comparison. * Inline JavaParser initializer instead of caching in field * Update generated recipes.csv
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new JUnit best practices recipe that removes the unnecessary delta/precision argument from
assertEquals()when both expected and actual areintorlongtypesInteger arguments get upcasted to
doublewhen a delta is provided, adding unnecessary complexityHandles both 3-arg (with delta) and 4-arg (with delta + message) variants, and both static import and qualified call styles
Registered in
JupiterBestPracticesrecipe listCloses
MigrateHamcrestToAssertJhandling of three argassertEqualswith numerical arguments #869Test plan