Fix PowerMockRunner removal leaving @Mock fields uninitialized#942
Merged
Fix PowerMockRunner removal leaving @Mock fields uninitialized#942
Conversation
…nner ReplacePowerMockito was ordered after AddMockitoExtensionIfAnnotationsUsed, so the latter would see @RunWith(PowerMockRunner.class) and skip the class. Then ReplacePowerMockito would remove it, leaving @mock fields uninitialized. Move ReplacePowerMockito before AddMockitoExtensionIfAnnotationsUsed so the runner gap is detected and filled with MockitoJUnitRunner or MockitoExtension.
timtebeek
approved these changes
Mar 26, 2026
github-project-automation
Bot
moved this from In Progress
to Ready to Review
in OpenRewrite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Mockito1to3Migrationremoved@RunWith(PowerMockRunner.class)without adding a replacement runner, leaving@Mockfields null at runtimeReplacePowerMockitoran afterAddMockitoExtensionIfAnnotationsUsedin the recipe chain, so the latter saw the existing@RunWithand skipped the classReplacePowerMockitobeforeMockitoJUnitToMockitoExtensionandAddMockitoExtensionIfAnnotationsUsedso the runner gap is detected and filled with@RunWith(MockitoJUnitRunner.class)(JUnit 4) or@ExtendWith(MockitoExtension.class)(JUnit 5)