-
Notifications
You must be signed in to change notification settings - Fork 102
Comparing changes
Open a pull request
base repository: openrewrite/rewrite-testing-frameworks
base: v3.34.0
head repository: openrewrite/rewrite-testing-frameworks
compare: v3.35.0
- 10 commits
- 25 files changed
- 6 contributors
Commits on Apr 8, 2026
-
Configuration menu - View commit details
-
Copy full SHA for 5243792 - Browse repository at this point
Copy the full SHA 5243792View commit details
Commits on Apr 10, 2026
-
OpenRewrite recipe best practices
Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.recipes.rewrite.OpenRewriteRecipeBestPractices?organizationId=QUxML01vZGVybmUvTW9kZXJuZSArIE9wZW5SZXdyaXRl Co-authored-by: Moderne <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 9e37a27 - Browse repository at this point
Copy the full SHA 9e37a27View commit details
Commits on Apr 11, 2026
-
Add MigrateToKafkaNative recipe for Testcontainers (#568) (#967)
* Add MigrateToKafkaNative recipe for Testcontainers (#568) * Address review feedback on ReplaceContainerImageName - Use @requiredargsconstructor with @Getter final fields for displayName/description - Make MethodMatcher a static field - Use UsesMethod precondition instead of UsesType - Also handle new DockerImageName(String) constructor calls * Regenerate recipes.csv for new recipes * Use @value instead of @requiredargsconstructor in ReplaceContainerImageName * Replace gvenzl/oracle-xe image in MigrateToOracleFree recipe * Update apache/kafka-native image to 4.0.2 * Add image replacements for ClickHouse, Toxiproxy, and Vault Replace deprecated Docker image names with their current equivalents: - yandex/clickhouse-server -> clickhouse/clickhouse-server - shopify/toxiproxy -> ghcr.io/shopify/toxiproxy - vault -> hashicorp/vault When newImage has no tag, the original tag is preserved.
Configuration menu - View commit details
-
Copy full SHA for 58bcc12 - Browse repository at this point
Copy the full SHA 58bcc12View commit details
Commits on Apr 13, 2026
-
Configuration menu - View commit details
-
Copy full SHA for ea72478 - Browse repository at this point
Copy the full SHA ea72478View commit details
Commits on Apr 15, 2026
-
Fix RemoveTryCatchFailBlocks failing when removing blocks within lamb…
…da expressions (#970) * Fix RemoveTryCatchFailBlocks failing when removing blocks within lambda expressions * Maybe this will fix test failure seen on CI * Disable the test because I don't care enough to investigate why it's failing on CI but not locally
Configuration menu - View commit details
-
Copy full SHA for 675b57d - Browse repository at this point
Copy the full SHA 675b57dView commit details
Commits on Apr 16, 2026
-
Use KotlinTypeUtils.isKotlinUnit to match Kotlin void return types (#971
) Follow-up to #970, which disabled `doNotChangeAlreadyUnitTestMethods` with comment "flaky on CI but I don't know why". Root cause: as of rewrite 8.79.4 (openrewrite/rewrite#7364), the Kotlin parser maps non-nullable `kotlin.Unit` to JVM `JavaType.Primitive.Void`. `TypeUtils.isOfClassType(type, "kotlin.Unit")` returns false for a primitive, so the recipe no longer skips already-Unit methods and rewrites them unnecessarily — tripping the single-cycle stability check on CI. Locally, stale `rewrite-kotlin` snapshots still carry the pre-change behaviour, which is why the failure was CI-only. Use `KotlinTypeUtils.isKotlinUnit` (introduced in the same PR #7364) which accepts either `JavaType.Primitive.Void` or a `kotlin.Unit` class reference, and re-enable the disabled test.
Configuration menu - View commit details
-
Copy full SHA for 83d1f44 - Browse repository at this point
Copy the full SHA 83d1f44View commit details
Commits on Apr 17, 2026
-
OpenRewrite recipe best practices
Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.recipes.rewrite.OpenRewriteRecipeBestPractices?organizationId=QUxML01vZGVybmUvTW9kZXJuZSArIE9wZW5SZXdyaXRl Co-authored-by: Moderne <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 13f0a17 - Browse repository at this point
Copy the full SHA 13f0a17View commit details -
Fix MockWebServer Dispatcher return type and RecordedRequest renames (#…
…972) * Fix MockWebServer Dispatcher return type and RecordedRequest renames Restore the `MockResponse` return type on `Dispatcher.dispatch()` overrides after the blanket `MockResponse` → `MockResponse.Builder` rename, wrapping return expressions with `.build()`. Also rename `RecordedRequest.getPath()` → `getTarget()` and `getRequestUrl()` → `getUrl()` to match mockwebserver3 5.x. * Prevent Dispatcher.dispatch() misconversion instead of correcting after Retarget UpdateMockWebServerDispatcher to match OLD (okhttp3.mockwebserver.*) types and run it before the blanket ChangeType, so dispatch() is pinned to mockwebserver3.MockResponse up front rather than reverted post-hoc. * Use JavaTemplate to replace dispatch() return type Drop the manual J.Identifier construction in favor of a JavaTemplate replace, which delegates type attribution to the parser and removes the Tree/Collections imports. * Regenerate recipes.csv for UpdateMockWebServerDispatcher * Use MethodMatcher for dispatch() override detection
Configuration menu - View commit details
-
Copy full SHA for f041383 - Browse repository at this point
Copy the full SHA f041383View commit details
Commits on Apr 18, 2026
-
Add @MockitoSettings(strictness = Strictness.WARN) for Mockito migrat…
…ion (#966) * Add @MockitoSettings(strictness = Strictness.WARN) support for Mockito migration Addresses the UnnecessaryStubbingException issue that occurs after migrating from Mockito 1.x, where unused stubbings were silently ignored but now fail under MockitoExtension's default STRICT_STUBS strictness. Two changes: 1. MockitoJUnitToMockitoExtension now adds @MockitoSettings even when @ExtendWith(MockitoExtension.class) is already present, preserving the original WARN strictness from the MockitoRule being removed. 2. New AddMockitoSettingsWithWarnStrictness recipe targets classes that already have @ExtendWith(MockitoExtension.class) but no MockitoRule to convert and no @MockitoSettings — the gap not covered by the existing recipe. * Fix oscillation: keep AddMockitoSettingsWithWarnStrictness standalone MockitoBestPractices includes RemoveAnnotation for @MockitoSettings(WARN), which conflicts with our recipe when both run in the same composite chain (e.g., JMockitToMockito → MockitoBestPractices → Mockito1to5Migration). Restore UsesType precondition and remove from Mockito1to3Migration chain. * Guard AddMockitoSettingsWithWarnStrictness with pre-3.0 Mockito precondition Introduces a declarative YAML wrapper `AddMockitoSettingsWithWarnStrictnessForLegacyMockito` that applies the underlying recipe only when the module depends on Mockito < 3.0. This avoids adding `@MockitoSettings(strictness = Strictness.WARN)` for projects that never used pre-3 Mockito defaults, while still preserving lenient behavior for Mockito 1.x/2.x migrations. * Refactor MockitoJUnitToMockitoExtension annotation handling Consolidate RunWith, ExtendWith, and MockitoSettings logic behind a single FindAnnotations check, move maybeAddImport calls next to their templates, and use a static import for Comparator.comparing. * Use direct return --------- Co-authored-by: Tim te Beek <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for e09430b - Browse repository at this point
Copy the full SHA e09430bView commit details
Commits on Apr 21, 2026
-
Extract documentation examples from tests
Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.java.recipes.ExamplesExtractor?organizationId=QUxML09wZW4gU291cmNlL09wZW5SZXdyaXRl Co-authored-by: Moderne <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 64260b8 - Browse repository at this point
Copy the full SHA 64260b8View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v3.34.0...v3.35.0