Support adding static imports for method invocations#140
Merged
Conversation
12 tasks
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Member
Author
|
Building on top of this work, and can't imagine there would be heavy criticism of this change, so merging already. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's your motivation?
Follow the instructions defined on rules to replace qualified method invocations with static imports.
Anything in particular you'd like reviewers to focus on?
I've limited this to top level
J.MethodInvocationonly, to cover a common case with as little complexity as possible.I've also optimistically assumed the goal is to always use static imports when the annotation is used, as per
https://github.com/search?q=repo%3APicnicSupermarket%2Ferror-prone-support+%22%40UseImportPolicy%28%22&type=code
Have you considered any alternatives or workarounds?
Handling annotation arguments is slightly awkward with assignments, and possible static imports, and not needed for now.
Handling anything beyond direct method invocations comes with a performance penalty as well, that I'd wanted to avoid.
Any additional context
UseStaticImportstwice in Include additional AssertJ rules/recipes from Error Prone Support rewrite-testing-frameworks#713