Skip to content

RemoveRedundantTypeCast should not remove required downcast#495

Merged
timtebeek merged 9 commits intoopenrewrite:mainfrom
protocol7:RemoveRedundantTypeCast-downcast
Jul 21, 2025
Merged

RemoveRedundantTypeCast should not remove required downcast#495
timtebeek merged 9 commits intoopenrewrite:mainfrom
protocol7:RemoveRedundantTypeCast-downcast

Conversation

@protocol7
Copy link
Copy Markdown
Contributor

@protocol7 protocol7 commented Apr 6, 2025

Adds a failing test case for where RemoveRedundantTypeCast should not remove a downcast that is necessary for chained calls to get matching types.

@sambsnyd
RemoveRedundantTypeCast should not remove required downcast
b4e4f2a 
Adds a failing test case for where RemoveRedundantTypeCast should not
remove a downcast that is necessary for chained calls to get matching
types.
@github-project-automation github-project-automation bot moved this to In Progress in OpenRewrite Apr 6, 2025
@protocol7 protocol7 mentioned this pull request Apr 6, 2025
Closed
github-actions[bot]
github-actions bot reviewed Apr 6, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • src/test/java/org/openrewrite/staticanalysis/RemoveRedundantTypeCastTest.java
    • lines 563-563

@timtebeek timtebeek added bug Something isn't working recipe labels Apr 6, 2025
@timtebeek
Copy link
Copy Markdown
Member

timtebeek commented Apr 6, 2025

Thanks for the runnable example!

@timtebeek timtebeek added the good first issue Good for newcomers label Apr 6, 2025
This was referenced Apr 11, 2025
Closed
Closed
@Pankraz76 Pankraz76 mentioned this pull request May 10, 2025
Closed
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 7, 2025

This PR is stale because it has been open for 90 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Jul 7, 2025
@timtebeek timtebeek removed the Stale label Jul 7, 2025
github-actions[bot]
github-actions bot reviewed Jul 7, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • src/main/java/org/openrewrite/staticanalysis/ExplicitLambdaArgumentTypes.java
    • lines 167-168

@timtebeek
Copy link
Copy Markdown
Member

timtebeek commented Jul 21, 2025

Summary

I successfully fixed the dontRemoveNecessaryDowncast test in RemoveRedundantTypeCastTest. The issue was that the recipe was incorrectly removing a type cast in a generic method call chain:

Optional.of((Bar) getBarImpl()).orElse(getBar())

The cast (Bar) is necessary here because:

  1. Without the cast, Optional.of(getBarImpl()) returns Optional<BarImpl>
  2. With the cast, Optional.of((Bar) getBarImpl()) returns Optional<Bar>
  3. The orElse(getBar()) method requires Optional<Bar> since getBar() returns Bar

The fix adds a special case check in the RemoveRedundantTypeCast recipe that preserves type casts when:

  1. The cast is inside a method invocation
  2. The cast is widening a type (e.g., from BarImpl to Bar)
  3. The method returns a parameterized (generic) type

This ensures that casts that affect generic type inference are preserved, preventing type compatibility issues in method chains.

github-actions[bot]
github-actions bot reviewed Jul 21, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • src/test/java/org/openrewrite/staticanalysis/RemoveRedundantTypeCastTest.java
    • lines 565-565

@timtebeek timtebeek self-assigned this Jul 21, 2025
@timtebeek timtebeek moved this from In Progress to Ready to Review in OpenRewrite Jul 21, 2025
@timtebeek timtebeek self-requested a review July 21, 2025 19:55
timtebeek
timtebeek approved these changes Jul 21, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@timtebeek timtebeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the help here @protocol7 ! The runnable test made this easy to tackle 🙏🏻

@timtebeek timtebeek merged commit 49c3ddf into openrewrite:main Jul 21, 2025
2 checks passed
@github-project-automation github-project-automation bot moved this from Ready to Review to Done in OpenRewrite Jul 21, 2025
@protocol7 protocol7 deleted the RemoveRedundantTypeCast-downcast branch July 21, 2025 20:07
@protocol7
Copy link
Copy Markdown
Contributor Author

protocol7 commented Jul 21, 2025

Nice work!

mergify bot added a commit to robfrank/linklift that referenced this pull request Aug 15, 2025
@mergify
chore(deps): bump org.openrewrite.recipe:rewrite-static-analysis from…
975e63a 
… 2.11.0 to 2.15.0 [skip ci]

Bumps [org.openrewrite.recipe:rewrite-static-analysis](https://github.com/openrewrite/rewrite-static-analysis) from 2.11.0 to 2.15.0.
Release notes

*Sourced from [org.openrewrite.recipe:rewrite-static-analysis's releases](https://github.com/openrewrite/rewrite-static-analysis/releases).*

> 2.15.0
> ------
>
> What's Changed
> --------------
>
> * Add parentheses in `CompareEnumsWithEqualityOperator` as needed by [`@​timtebeek`](https://github.com/timtebeek) in [openrewrite/rewrite-static-analysis#658](https://redirect.github.com/openrewrite/rewrite-static-analysis/pull/658)
> * Recipe to simplify Boolean expressions using De Morgan's laws by [`@​greg-at-moderne`](https://github.com/greg-at-moderne) in [openrewrite/rewrite-static-analysis#659](https://redirect.github.com/openrewrite/rewrite-static-analysis/pull/659)
> * SimplifyBooleanExpressionWithDeMorgan - Add parens when converting to OR by [`@​greg-at-moderne`](https://github.com/greg-at-moderne) in [openrewrite/rewrite-static-analysis#660](https://redirect.github.com/openrewrite/rewrite-static-analysis/pull/660)
> * UseForEachLoop recipe by [`@​greg-at-moderne`](https://github.com/greg-at-moderne) in [openrewrite/rewrite-static-analysis#651](https://redirect.github.com/openrewrite/rewrite-static-analysis/pull/651)
> * Do not remove used private fields after type change by [`@​timtebeek`](https://github.com/timtebeek) in [openrewrite/rewrite-static-analysis#648](https://redirect.github.com/openrewrite/rewrite-static-analysis/pull/648)
> * UseForEachLoop - not to change in case of array assignment by [`@​greg-at-moderne`](https://github.com/greg-at-moderne) in [openrewrite/rewrite-static-analysis#661](https://redirect.github.com/openrewrite/rewrite-static-analysis/pull/661)
> * Remove UseForEachLoop by [`@​greg-at-moderne`](https://github.com/greg-at-moderne) in [openrewrite/rewrite-static-analysis#662](https://redirect.github.com/openrewrite/rewrite-static-analysis/pull/662)
> * Fixing `twoCases` test case in `MinimumSwitchCasesTest` by [`@​greg-at-moderne`](https://github.com/greg-at-moderne) in [openrewrite/rewrite-static-analysis#672](https://redirect.github.com/openrewrite/rewrite-static-analysis/pull/672)
> * Fixing code suggestions by [`@​greg-at-moderne`](https://github.com/greg-at-moderne) in [openrewrite/rewrite-static-analysis#673](https://redirect.github.com/openrewrite/rewrite-static-analysis/pull/673)
> * Keep indentation when running `FinalizePrivateFields` by [`@​jevanlingen`](https://github.com/jevanlingen) in [openrewrite/rewrite-static-analysis#675](https://redirect.github.com/openrewrite/rewrite-static-analysis/pull/675)
> * PreferIncrementOperator by [`@​greg-at-moderne`](https://github.com/greg-at-moderne) in [openrewrite/rewrite-static-analysis#676](https://redirect.github.com/openrewrite/rewrite-static-analysis/pull/676)
> * Add MavenJavadocNonAsciiRecipe to remove non-ASCII characters from Ja… by [`@​sfarhaazmi`](https://github.com/sfarhaazmi) in [openrewrite/rewrite-static-analysis#674](https://redirect.github.com/openrewrite/rewrite-static-analysis/pull/674)
> * refactor: Static imports for Collections and Collectors by [`@​timtebeek`](https://github.com/timtebeek) in [openrewrite/rewrite-static-analysis#678](https://redirect.github.com/openrewrite/rewrite-static-analysis/pull/678)
> * PreferIncrementOperator - more coverage - compound assignment operators by [`@​greg-at-moderne`](https://github.com/greg-at-moderne) in [openrewrite/rewrite-static-analysis#680](https://redirect.github.com/openrewrite/rewrite-static-analysis/pull/680)
> * rename settings.local.json to settings.json by [`@​zieka`](https://github.com/zieka) in [openrewrite/rewrite-static-analysis#690](https://redirect.github.com/openrewrite/rewrite-static-analysis/pull/690)
> * Add PreferEqualityComparisonOverDifferenceCheck recipe by [`@​e5LA`](https://github.com/e5LA) in [openrewrite/rewrite-static-analysis#686](https://redirect.github.com/openrewrite/rewrite-static-analysis/pull/686)
> * Applying code suggestions by [`@​greg-at-moderne`](https://github.com/greg-at-moderne) in [openrewrite/rewrite-static-analysis#693](https://redirect.github.com/openrewrite/rewrite-static-analysis/pull/693)
> * Show a failure to remove some semicolons still by [`@​timtebeek`](https://github.com/timtebeek) in [openrewrite/rewrite-static-analysis#697](https://redirect.github.com/openrewrite/rewrite-static-analysis/pull/697)
> * `MoveConditionsToWhile` recipe by [`@​greg-at-moderne`](https://github.com/greg-at-moderne) in [openrewrite/rewrite-static-analysis#698](https://redirect.github.com/openrewrite/rewrite-static-analysis/pull/698)
> * Add Claude derived instructions for tests and recipes by [`@​timtebeek`](https://github.com/timtebeek) in [openrewrite/rewrite-static-analysis#700](https://redirect.github.com/openrewrite/rewrite-static-analysis/pull/700)
> * Fix NPE for new arrays with initializers in `ReplaceCollectionToArrayArgWithEmptyArray` by [`@​greg-at-moderne`](https://github.com/greg-at-moderne) in [openrewrite/rewrite-static-analysis#704](https://redirect.github.com/openrewrite/rewrite-static-analysis/pull/704)
> * Add `RemoveRedundantNullCheckBeforeLiteralEquals` by [`@​timtebeek`](https://github.com/timtebeek) in [openrewrite/rewrite-static-analysis#706](https://redirect.github.com/openrewrite/rewrite-static-analysis/pull/706)
> * Refactor RewriteTest to use defaults method by [`@​timtebeek`](https://github.com/timtebeek) in [openrewrite/rewrite-static-analysis#707](https://redirect.github.com/openrewrite/rewrite-static-analysis/pull/707)
>
> New Contributors
> ----------------
>
> * [`@​sfarhaazmi`](https://github.com/sfarhaazmi) made their first contribution in [openrewrite/rewrite-static-analysis#674](https://redirect.github.com/openrewrite/rewrite-static-analysis/pull/674)
> * [`@​zieka`](https://github.com/zieka) made their first contribution in [openrewrite/rewrite-static-analysis#690](https://redirect.github.com/openrewrite/rewrite-static-analysis/pull/690)
> * [`@​e5LA`](https://github.com/e5LA) made their first contribution in [openrewrite/rewrite-static-analysis#686](https://redirect.github.com/openrewrite/rewrite-static-analysis/pull/686)
>
> **Full Changelog**: <openrewrite/rewrite-static-analysis@v2.14.0...v2.15.0>
>
> 2.14.0
> ------
>
> What's Changed
> --------------
>
> * Heap size of 1G for tests by [`@​greg-at-moderne`](https://github.com/greg-at-moderne) in [openrewrite/rewrite-static-analysis#653](https://redirect.github.com/openrewrite/rewrite-static-analysis/pull/653)
> * UnwrapElseAfterReturn - dealing with trailing comments by [`@​greg-at-moderne`](https://github.com/greg-at-moderne) in [openrewrite/rewrite-static-analysis#654](https://redirect.github.com/openrewrite/rewrite-static-analysis/pull/654)
> * Dealing with even more kinds of trailing comments in UnwrapElseAfterReturn by [`@​greg-at-moderne`](https://github.com/greg-at-moderne) in [openrewrite/rewrite-static-analysis#655](https://redirect.github.com/openrewrite/rewrite-static-analysis/pull/655)
>
> **Full Changelog**: <openrewrite/rewrite-static-analysis@v2.13.0...v2.14.0>
>
> 2.13.0
> ------
>
> What's Changed
> --------------
>
> * Add CollectionToArrayShouldHaveProperType recipe (RSPEC-S3020) by [`@​jkschneider`](https://github.com/jkschneider) in [openrewrite/rewrite-static-analysis#635](https://redirect.github.com/openrewrite/rewrite-static-analysis/pull/635)
> * Fix `UnnecessaryCatch` Recipe Multi-Catch Handling by [`@​stefanodallapalma`](https://github.com/stefanodallapalma) in [openrewrite/rewrite-static-analysis#638](https://redirect.github.com/openrewrite/rewrite-static-analysis/pull/638)
> * Add `OnlyCatchDeclaredExceptions` recipe to address RSPEC-S2221 by [`@​stefanodallapalma`](https://github.com/stefanodallapalma) in [openrewrite/rewrite-static-analysis#601](https://redirect.github.com/openrewrite/rewrite-static-analysis/pull/601)
> * RemoveRedundantTypeCast should not remove required downcast by [`@​protocol7`](https://github.com/protocol7) in [openrewrite/rewrite-static-analysis#495](https://redirect.github.com/openrewrite/rewrite-static-analysis/pull/495)
> * Unwrap else after return in preceding `if` by [`@​timtebeek`](https://github.com/timtebeek) in [openrewrite/rewrite-static-analysis#645](https://redirect.github.com/openrewrite/rewrite-static-analysis/pull/645)
> * Extend `InlineVariable` to support local variable assignments by [`@​timtebeek`](https://github.com/timtebeek) in [openrewrite/rewrite-static-analysis#647](https://redirect.github.com/openrewrite/rewrite-static-analysis/pull/647)

... (truncated)


Commits

* [`e5ca752`](openrewrite/rewrite-static-analysis@e5ca752) OpenRewrite recipe best practices
* [`976d366`](openrewrite/rewrite-static-analysis@976d366) Retain `writeReplace` in `RemoveUnusedPrivateMethods`
* [`76322bc`](openrewrite/rewrite-static-analysis@76322bc) Refactor RewriteTest to use defaults method ([#707](https://redirect.github.com/openrewrite/rewrite-static-analysis/issues/707))
* [`e5926ef`](openrewrite/rewrite-static-analysis@e5926ef) Add `RemoveRedundantNullCheckBeforeLiteralEquals` ([#706](https://redirect.github.com/openrewrite/rewrite-static-analysis/issues/706))
* [`6547c82`](openrewrite/rewrite-static-analysis@6547c82) OpenRewrite recipe best practices
* [`c4c5941`](openrewrite/rewrite-static-analysis@c4c5941) Fix NPE for new arrays with initializers in `ReplaceCollectionToArrayArgWithE...
* [`428d8b0`](openrewrite/rewrite-static-analysis@428d8b0) Add Claude derived instructions for tests and recipes ([#700](https://redirect.github.com/openrewrite/rewrite-static-analysis/issues/700))
* [`e775b10`](openrewrite/rewrite-static-analysis@e775b10) Polish `MoveConditionsToWhile`
* [`dbabed5`](openrewrite/rewrite-static-analysis@dbabed5) `MoveConditionsToWhile` recipe ([#698](https://redirect.github.com/openrewrite/rewrite-static-analysis/issues/698))
* [`a5a709c`](openrewrite/rewrite-static-analysis@a5a709c) Show a failure to remove some semicolons still ([#697](https://redirect.github.com/openrewrite/rewrite-static-analysis/issues/697))
* Additional commits viewable in [compare view](openrewrite/rewrite-static-analysis@v2.11.0...v2.15.0)
  
[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility\_score?dependency-name=org.openrewrite.recipe:rewrite-static-analysis&package-manager=maven&previous-version=2.11.0&new-version=2.15.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
Dependabot commands and options
  
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show  ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@timtebeek timtebeek timtebeek approved these changes

Assignees

@protocol7 protocol7

@timtebeek timtebeek

Labels

bug Something isn't working good first issue Good for newcomers recipe

Projects

OpenRewrite
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@protocol7 @timtebeek @sambsnyd @knutwannheden