Skip to content

CompareEnumsWithEqualityOperator fails with negation #3

@koppor

Description

@koppor

https://github.com/JabRef/jabref/blob/913b46cf0c31a4f7f73c84e4a8584c9adb8c701f/src/main/java/org/jabref/gui/journals/UndoableUnabbreviator.java#L61

if ((!StandardField.JOURNAL.equals(field) && !StandardField.JOURNALTITLE.equals(field)) || !entry.hasField(AMSField.FJOURNAL)) {

gets rewritten to

if ((!StandardField.JOURNAL != field && StandardField.JOURNALTITLE != field) || !entry.hasField(AMSField.FJOURNAL)) {

Which leads to a compile error

C:\git-repositories\jabref\src\main\java\org\jabref\gui\journals\UndoableUnabbreviator.java:61: Fehler: Ungültiger Operandentyp StandardField für unären Operator "!"
        if ((!StandardField.JOURNAL != field && StandardField.JOURNALTITLE != field) || !entry.hasField(AMSField.FJOURNAL)) {
             ^

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

Status

Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions