Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: openrewrite/rewrite-static-analysis
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v2.19.0
Choose a base ref
...
head repository: openrewrite/rewrite-static-analysis
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v2.20.0
Choose a head ref
  • 7 commits
  • 10 files changed
  • 3 contributors

Commits on Oct 14, 2025

  1. Configuration menu
    Copy the full SHA
    b92d93a View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2025

  1. 4 Configuration menu
    Copy the full SHA
    c195a4f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a84f525 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2025

  1. Configuration menu
    Copy the full SHA
    4c8fa35 View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2025

  1. Fix EqualsAvoidsNull to remove redundant null checks when literal is …

    …already on left side (#756)
    
    * Fix EqualsAvoidsNull to remove redundant null checks when literal is already on left side
    
    The recipe was failing to remove redundant null checks in patterns like:
      if (s != null && "test".equals(s)) {}
    
    The issue was that visitMethodInvocation would return early before calling
    maybeHandleParentBinary when the select was already a literal. This prevented
    the null check removal logic from running.
    
    Additionally, maybeHandleParentBinary only checked if the null check matched
    the select of the method invocation, but not the argument. For cases where the
    literal is already on the left side (select), we need to check if the null
    check matches the argument.
    
    Changes:
    - Moved maybeHandleParentBinary call before early returns to ensure null check
      removal is always attempted for string comparison methods
    - Extended null check matching to check both select and argument expressions
    - Added comment clarifying that null check removal runs independently of
      argument swapping logic
    
    Fixes: org.openrewrite.staticanalysis.EqualsAvoidsNullTest#removeUnnecessaryNullCheckByItself
    
    🤖 Generated with [Claude Code](https://claude.com/claude-code)
    
    Co-Authored-By: Claude <[email protected]>
    
    * Update description
    
    * Expand unit test
    
    * Replace local methods with existing utilities to expand coverage
    
    * Add parentheses and format to see repetition
    
    ---------
    
    Co-authored-by: Claude <[email protected]>
    timtebeek and claude authored Oct 20, 2025
    Configuration menu
    Copy the full SHA
    b6d6d94 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2025

  1. Configuration menu
    Copy the full SHA
    ce75f31 View commit details
    Browse the repository at this point in the history
  2. Fix RemoveUnusedPrivateFields for Lombok annotations after visibility…

    … modifiers (#759)
    
    * Fix RemoveUnusedPrivateFields to detect annotations after visibility modifiers
    
    The recipe was incorrectly removing Lombok-annotated fields when the annotation
    was placed after the visibility modifier (e.g., `private @Getter String foo;`)
    instead of before it (e.g., `@Getter private String foo;`).
    
    The fix adds a helper method `hasAnyAnnotations()` that checks for both:
    - Leading annotations (before modifiers)
    - Type annotations (after modifiers, stored as J.AnnotatedType)
    
    Fixes #757
    
    🤖 Generated with [Claude Code](https://claude.com/claude-code)
    
    Co-Authored-By: Claude <[email protected]>
    
    * Simplify approach
    
    ---------
    
    Co-authored-by: Claude <[email protected]>
    timtebeek and claude authored Oct 22, 2025
    Configuration menu
    Copy the full SHA
    241a923 View commit details
    Browse the repository at this point in the history
Loading