Skip to content

Update other websocket apis for javax to jakarta#740

Merged
timtebeek merged 2 commits into
openrewrite:mainfrom
evie-lau:websocket
May 27, 2025
Merged

Update other websocket apis for javax to jakarta#740
timtebeek merged 2 commits into
openrewrite:mainfrom
evie-lau:websocket

Conversation

@evie-lau

@evie-lau evie-lau commented May 22, 2025

Copy link
Copy Markdown
Contributor

What's changed?

Update the other websocket APIs in EE9 and EE10 migration.
Originally only updated websocket-api, now including websocket-client-api and websocket-all

What's your motivation?

Anything in particular you'd like reviewers to focus on?

Anyone you would like to review specifically?

Have you considered any alternatives or workarounds?

Any additional context

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

@evie-lau evie-lau self-assigned this May 22, 2025
@github-project-automation github-project-automation Bot moved this to In Progress in OpenRewrite May 22, 2025

@timtebeek timtebeek left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the expanded coverage!

@github-project-automation github-project-automation Bot moved this from In Progress to Ready to Review in OpenRewrite May 27, 2025
@timtebeek timtebeek merged commit d2a747c into openrewrite:main May 27, 2025
2 checks passed
@github-project-automation github-project-automation Bot moved this from Ready to Review to Done in OpenRewrite May 27, 2025
@evie-lau evie-lau deleted the websocket branch May 27, 2025 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants