Add acceptTransitive to javax-to-jakarta AddDependency entries#1034
Merged
steve-aom-elliott merged 1 commit intomainfrom Mar 30, 2026
Merged
Add acceptTransitive to javax-to-jakarta AddDependency entries#1034steve-aom-elliott merged 1 commit intomainfrom
steve-aom-elliott merged 1 commit intomainfrom
Conversation
Without acceptTransitive, AddDependency adds the jakarta dependency even when it is already available transitively (e.g. via Spring Boot starters). This caused rewrite-spring Boot3UpgradeTest.xmlBindMissing to fail because jakarta.persistence-api and jakarta.validation-api were being added explicitly despite being transitive through spring-boot-starter-data-jpa and spring-boot-starter-validation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
acceptTransitive: trueto all 25AddDependencyentries injakarta-ee-9.ymlthat were missing itAddDependencyadds the jakarta dependency as an explicit dependency even when it's already available transitively (e.g. via Spring Boot starters likespring-boot-starter-data-jpaorspring-boot-starter-validation)Boot3UpgradeTest.xmlBindMissing()failure in rewrite-spring caused byjakarta.persistence-apiandjakarta.validation-apibeing unnecessarily added as explicit dependenciesTest plan
Boot3UpgradeTest.xmlBindMissing()now passes with local snapshot