Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: openrewrite/rewrite-migrate-java
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v3.31.1
Choose a base ref
...
head repository: openrewrite/rewrite-migrate-java
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v3.31.2
Choose a head ref
  • 4 commits
  • 11 files changed
  • 3 contributors

Commits on Mar 30, 2026

  1. Only add lombok annotation processor to modules that use lombok (#1031) 

    * Add test reproducing lombok annotation processor bug in multi-module projects

RepositoryHasDependency marks all files if any module has lombok,
causing AddAnnotationProcessor to run on modules without lombok.

* Use per-module DependencyInsight precondition for EnableLombokAnnotationProcessor

RepositoryHasDependency checks the whole repo and marks ALL files when
any module has lombok, causing AddAnnotationProcessor to run on modules
without lombok. Switch to DependencyInsight which checks per-module,
matching the pattern used by AddLombokMapstructBinding.

Fixes moderneinc/customer-requests#2110

* Remove nested parent/child test that can't work with DependencyInsight

DependencyInsight doesn't resolve dependencies in nested mavenProject
test structures (test infrastructure limitation). The sibling mavenProject
test already proves the per-module behavior correctly.

* Use ModuleHasDependency instead of DependencyInsight for per-module precision

Switch to ModuleHasDependency which is designed as a per-module precondition
using ScanningRecipe to collect JavaProject markers. This is the proper
counterpart to RepositoryHasDependency for module-scoped checks, and removes
the need for the Singleton wrapper.

* Assert annotation processor is added in multi-module test
    @Jenson3210
    Jenson3210 authored Mar 30, 2026
    Configuration menu
    Copy the full SHA
    317ca42 View commit details
    Browse the repository at this point in the history

  2. [Auto] SDKMAN! Java candidates as of 2026-03-30T1057

    @TeamModerne
    TeamModerne committed Mar 30, 2026
    Configuration menu
    Copy the full SHA
    1ee17ae View commit details
    Browse the repository at this point in the history

  3. Add missing AddDependency fallback for jakarta.servlet.jsp-api in JSP… 

    … migration (#1032)
    @steve-aom-elliott
    steve-aom-elliott authored Mar 30, 2026
    Configuration menu
    Copy the full SHA
    af026f0 View commit details
    Browse the repository at this point in the history

  4. Add missing AddDependency fallback entries for all javax-to-jakarta m… 

    …igrations (#1033)
    @steve-aom-elliott
    steve-aom-elliott authored Mar 30, 2026
    1 Configuration menu
    Copy the full SHA
    bef57d1 View commit details
    Browse the repository at this point in the history
Loading