Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: openrewrite/rewrite-migrate-java
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v2.22.1
Choose a base ref
...
head repository: openrewrite/rewrite-migrate-java
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v2.23.0
Choose a head ref
  • 8 commits
  • 47 files changed
  • 9 contributors

Commits on Aug 15, 2024

  1. Migrate to JSpecify from OpenRewrite JSR-305 meta-annotations (#537) 

    * Migrate to JSpecify from OpenRewrite JSR-305 meta-annotations

Use this link to re-run the recipe: https://app.moderne.io/builder/gW3xaSLWV?organizationId=T3BlblJld3JpdGU%3D

Co-authored-by: Moderne <[email protected]>

* Remove field level NonNull annotations

---------

Co-authored-by: Moderne <[email protected]>
Co-authored-by: Tim te Beek <[email protected]>
    @jkschneider @TeamModerne @timtebeek
    3 people authored Aug 15, 2024
    Configuration menu
    Copy the full SHA
    3dfcc4f View commit details
    Browse the repository at this point in the history

  2. Handle generics in PreferJavaUtilObjectsRequireNonNull (#538) 

    * Handle generics in PreferJavaUtilObjectsRequireNonNull

Before this patch, the PreferJavaUtilObjectsRequireNonNull recipe
would only migrate usage of exactly `checkNotNull(Object)` but not
any other (sub)types.

We now match invocations of checkNotNull with exactly one or two
arguments (both in refaster). Note that there is also a three
argument version that doesn't have a straight-forward replacement,
I skipped that for now and added a testcase.

* Expect non-static import for now

* Exclusively test with generated NoGuavaRefasterRecipes

* Use a unique name for the new recipe

* Suppress warning

---------

Co-authored-by: Tim te Beek <[email protected]>
    @mbruggmann @timtebeek
    mbruggmann and timtebeek authored Aug 15, 2024
    Configuration menu
    Copy the full SHA
    b525041 View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2024

  1. Force clean up of lombok.var import 

    Fixes #539
    @timtebeek
    timtebeek committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    3d8fbd0 View commit details
    Browse the repository at this point in the history

  2. refactor: Simplify lambda blocks to expressions 

    Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.staticanalysis.LambdaBlockToExpression?organizationId=T3BlblJld3JpdGU%3D

Co-authored-by: Moderne <[email protected]>
    @timtebeek @TeamModerne
    2 people authored and app committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    77eda2c View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2024

  1. refactor: Remove unused imports 

    Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.java.RemoveUnusedImports?organizationId=T3BlblJld3JpdGU%3D

Co-authored-by: Moderne <[email protected]>
    @timtebeek @TeamModerne
    timtebeek and TeamModerne committed Aug 18, 2024
    Configuration menu
    Copy the full SHA
    7bf7506 View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2024

  1. Recipe ReplaceLocalizedStreamMethods (#532) 

    * Recipe for LocalizedStreamMethods

* Formatted the file

* Remove RemovedLogManagerPropertyChangeListenerMethods for now

* Fix compilation and other suggested fixes

* Retain original prefix

* Apply suggestions from code review

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Updated the getDisplayName and getDescription

* Modified as mentioned in Comments

* Updated the description

* Update ReplaceLocalizedStreamMethods.java

* Update ReplaceLocalizedStreamMethods.java

---------

Co-authored-by: bhavanapidapa <[email protected]>
Co-authored-by: Tim te Beek <[email protected]>
Co-authored-by: Tim te Beek <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
    @BhavanaPidapa @timtebeek @github-actions
    5 people authored Aug 20, 2024
    Configuration menu
    Copy the full SHA
    270244c View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2024

  1. refactor: OpenRewrite best practices 

    Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.recipes.OpenRewriteBestPractices?organizationId=T3BlblJld3JpdGU%3D

Co-authored-by: Moderne <[email protected]>
    @timtebeek @TeamModerne
    timtebeek and TeamModerne committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    e638cbe View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2024

  1. Migrate a few more OpenRewrite nullability annotations 

    Use this link to re-run the recipe: https://app.moderne.io/builder/rCfr27H6r?organizationId=T3BlblJld3JpdGU%3D

Co-authored-by: Moderne <[email protected]>
    @knutwannheden @TeamModerne
    knutwannheden and TeamModerne committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    30c79c0 View commit details
    Browse the repository at this point in the history
Loading