Fix Jackson 2.21+ compatibility for JREThrowableFinalMethods (#1010)

timtebeek · web-flow · commit c421ab14c37a · 2026-03-16T23:20:11.000+01:00
Remove @requiredargsconstructor which generates @ConstructorProperties on the all-args constructor, conflicting with the no-arg @JsonCreator. Change @JsonCreator to accept nullable parameters with defaults, matching the pattern from #1007. This resolves the InvalidDefinitionException: Conflicting property-based creators reported in issue #1003.
diff --git a/src/main/java/org/openrewrite/java/migrate/JREThrowableFinalMethods.java b/src/main/java/org/openrewrite/java/migrate/JREThrowableFinalMethods.java
@@ -16,10 +16,9 @@
 package org.openrewrite.java.migrate;
 
 import com.fasterxml.jackson.annotation.JsonCreator;
-import lombok.AccessLevel;
 import lombok.EqualsAndHashCode;
 import lombok.Getter;
-import lombok.RequiredArgsConstructor;
+import org.jspecify.annotations.Nullable;
 import org.openrewrite.ExecutionContext;
 import org.openrewrite.Preconditions;
 import org.openrewrite.Recipe;
@@ -33,16 +32,19 @@
 import org.openrewrite.java.tree.TypeUtils;
 
 @EqualsAndHashCode(callSuper = false)
-@RequiredArgsConstructor(access = AccessLevel.PACKAGE)
 public class JREThrowableFinalMethods extends Recipe {
 
     private final String methodPatternAddSuppressed;
     private final String methodPatternGetSuppressed;
 
     @JsonCreator
-    public JREThrowableFinalMethods() {
-        this.methodPatternAddSuppressed = "*..* addSuppressed(Throwable)";
-        this.methodPatternGetSuppressed = "*..* getSuppressed()";
+    public JREThrowableFinalMethods(
+            @Nullable String methodPatternAddSuppressed,
+            @Nullable String methodPatternGetSuppressed) {
+        this.methodPatternAddSuppressed = methodPatternAddSuppressed == null ?
+                "*..* addSuppressed(Throwable)" : methodPatternAddSuppressed;
+        this.methodPatternGetSuppressed = methodPatternGetSuppressed == null ?
+                "*..* getSuppressed()" : methodPatternGetSuppressed;
     }
 
     @Getter
diff --git a/src/test/java/org/openrewrite/java/migrate/JREThrowableFinalMethodsTest.java b/src/test/java/org/openrewrite/java/migrate/JREThrowableFinalMethodsTest.java
@@ -91,7 +91,7 @@ void methodUsingException(ThrowableWithIllegalOverrrides t1) {
     void shouldRenameOnJava6() {
         //language=java
         rewriteRun(
-          spec -> spec.recipe(new JREThrowableFinalMethods()),
+          spec -> spec.recipe(new JREThrowableFinalMethods(null, null)),
           java(
             """
               class ClassUsingThrowable {
@@ -118,7 +118,7 @@ void methodUsingRenamedMethodsAlready(Throwable t1) {
     void shouldNotRenameOnJava7() {
         //language=java
         rewriteRun(
-          spec -> spec.recipe(new JREThrowableFinalMethods()),
+          spec -> spec.recipe(new JREThrowableFinalMethods(null, null)),
           java(
             """
               class ClassUsingThrowable {
