Lombok Best Practices

timtebeek · TeamModerne · app · commit 5ff744350c24 · 2026-03-11T22:32:10.000Z
Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.java.migrate.lombok.LombokBestPractices?organizationId=QUxML01vZGVybmUvTW9kZXJuZSArIE9wZW5SZXdyaXRl Co-authored-by: Moderne <team@moderne.io>
diff --git a/src/main/java/org/openrewrite/java/migrate/JREThrowableFinalMethods.java b/src/main/java/org/openrewrite/java/migrate/JREThrowableFinalMethods.java
@@ -16,8 +16,10 @@
 package org.openrewrite.java.migrate;
 
 import com.fasterxml.jackson.annotation.JsonCreator;
+import lombok.AccessLevel;
 import lombok.EqualsAndHashCode;
 import lombok.Getter;
+import lombok.RequiredArgsConstructor;
 import org.openrewrite.ExecutionContext;
 import org.openrewrite.Preconditions;
 import org.openrewrite.Recipe;
@@ -31,6 +33,7 @@
 import org.openrewrite.java.tree.TypeUtils;
 
 @EqualsAndHashCode(callSuper = false)
+@RequiredArgsConstructor(access = AccessLevel.PACKAGE)
 public class JREThrowableFinalMethods extends Recipe {
 
     private final String methodPatternAddSuppressed;
@@ -42,14 +45,6 @@ public JREThrowableFinalMethods() {
         this.methodPatternGetSuppressed = "*..* getSuppressed()";
     }
 
-    /**
-     * Overload constructor to allow for custom method patterns used in tests only.
-     */
-    JREThrowableFinalMethods(String methodPatternAddSuppressed, String methodPatternGetSuppressed) {
-        this.methodPatternAddSuppressed = methodPatternAddSuppressed;
-        this.methodPatternGetSuppressed = methodPatternGetSuppressed;
-    }
-
     @Getter
     final String displayName = "Rename final method declarations `getSuppressed()` and `addSuppressed(Throwable exception)` in classes that extend `Throwable`";
 
diff --git a/src/main/java/org/openrewrite/java/migrate/MigrateGraalVMResourceConfig.java b/src/main/java/org/openrewrite/java/migrate/MigrateGraalVMResourceConfig.java
@@ -15,7 +15,9 @@
  */
 package org.openrewrite.java.migrate;
 
+import lombok.AccessLevel;
 import lombok.EqualsAndHashCode;
+import lombok.RequiredArgsConstructor;
 import lombok.Value;
 import org.jspecify.annotations.Nullable;
 import org.openrewrite.*;
@@ -161,14 +163,10 @@ public Json.Document visitDocument(Json.Document document, ExecutionContext ctx)
             return doc;
         }
 
+        @RequiredArgsConstructor(access = AccessLevel.PACKAGE)
         private static final class ConvertedEntry {
             final Json.JsonObject entry;
             final boolean hasWarning;
-
-            ConvertedEntry(Json.JsonObject entry, boolean hasWarning) {
-                this.entry = entry;
-                this.hasWarning = hasWarning;
-            }
         }
 
         private @Nullable ConvertedEntry convertPatternEntry(Json.JsonObject entryObj) {
@@ -309,15 +307,11 @@ private static String escapeJsonString(String s) {
 
         // Regex to glob conversion logic integrated from RegexToGlobConverter
 
+        @RequiredArgsConstructor(access = AccessLevel.PACKAGE)
         private static final class ConversionResult {
             final @Nullable String glob;
             final @Nullable String warningMessage;
 
-            ConversionResult(@Nullable String glob, @Nullable String warningMessage) {
-                this.glob = glob;
-                this.warningMessage = warningMessage;
-            }
-
             boolean isSuccessful() {
                 return glob != null;
             }
diff --git a/src/main/java/org/openrewrite/java/migrate/guava/AbstractNoGuavaImmutableOf.java b/src/main/java/org/openrewrite/java/migrate/guava/AbstractNoGuavaImmutableOf.java
@@ -15,7 +15,9 @@
  */
 package org.openrewrite.java.migrate.guava;
 
+import lombok.AccessLevel;
 import lombok.Getter;
+import lombok.RequiredArgsConstructor;
 import org.jspecify.annotations.Nullable;
 import org.openrewrite.*;
 import org.openrewrite.internal.ListUtils;
@@ -33,6 +35,7 @@
 
 import static java.util.Collections.emptyList;
 
+@RequiredArgsConstructor(access = AccessLevel.PACKAGE)
 abstract class AbstractNoGuavaImmutableOf extends Recipe {
 
     private final String guavaType;
@@ -46,11 +49,6 @@ abstract class AbstractNoGuavaImmutableOf extends Recipe {
     @Nullable
     Boolean convertReturnType;
 
-    AbstractNoGuavaImmutableOf(String guavaType, String javaType) {
-        this.guavaType = guavaType;
-        this.javaType = javaType;
-    }
-
     AbstractNoGuavaImmutableOf(String guavaType, String javaType, @Nullable Boolean convertReturnType) {
         this.guavaType = guavaType;
         this.javaType = javaType;
diff --git a/src/main/java/org/openrewrite/java/migrate/lombok/LombokValueToRecord.java b/src/main/java/org/openrewrite/java/migrate/lombok/LombokValueToRecord.java
@@ -212,6 +212,7 @@ private boolean hasMemberVariableAssignments(List<J.VariableDeclarations> member
 
     }
 
+    @RequiredArgsConstructor
     private static class LombokValueToRecordVisitor extends JavaIsoVisitor<ExecutionContext> {
         private static final JavaTemplate TO_STRING_TEMPLATE = JavaTemplate
                 .builder("@Override public String toString() { return \"#{}(\" +\n#{}\n\")\"; }")
@@ -226,11 +227,6 @@ private static class LombokValueToRecordVisitor extends JavaIsoVisitor<Execution
         private final @Nullable Boolean useExactToString;
         private final Map<String, Set<String>> recordTypeToMembers;
 
-        public LombokValueToRecordVisitor(@Nullable Boolean useExactToString, Map<String, Set<String>> recordTypeToMembers) {
-            this.useExactToString = useExactToString;
-            this.recordTypeToMembers = recordTypeToMembers;
-        }
-
         @Override
         public J.MethodInvocation visitMethodInvocation(J.MethodInvocation method, ExecutionContext ctx) {
             J.MethodInvocation methodInvocation = super.visitMethodInvocation(method, ctx);
