Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: openrewrite/rewrite-logging-frameworks
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v3.12.0
Choose a base ref
...
head repository: openrewrite/rewrite-logging-frameworks
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v3.13.0
Choose a head ref
  • 11 commits
  • 23 files changed
  • 8 contributors

Commits on Jul 25, 2025

  1. Do not reduce visibility of logger field in abstract class

    @timtebeek
    timtebeek committed Jul 25, 2025
    Configuration menu
    Copy the full SHA
    c185014 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2025

  1. Recipe to migrate deprecated JBoss Logging calls (#245) 

    * Recipe to migrate deprecated JBoss Logging calls

* `DocumentExample` does not support `ParameterizedTest`

* Show for now expected conversion of explicit object array

---------

Co-authored-by: Tim te Beek <[email protected]>
    @pdelagrave @timtebeek
    pdelagrave and timtebeek authored Jul 30, 2025
    Configuration menu
    Copy the full SHA
    af44c67 View commit details
    Browse the repository at this point in the history

  2. refactor: Static imports for Collections and Collectors 

    Use this link to re-run the recipe: https://app.moderne.io/builder/m9HsHwu2Z?organizationId=ODQ2MGExMTUtNDg0My00N2EwLTgzMGMtNGE1NGExMTBmZDkw

Co-authored-by: Moderne <[email protected]>
    @timtebeek @TeamModerne
    2 people authored and app committed Jul 30, 2025
    Configuration menu
    Copy the full SHA
    ce8bc2d View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2025

  1. Create Claude settings file 

    Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.text.CreateTextFile?organizationId=QUxML09wZW4gU291cmNlL09wZW5SZXdyaXRl#defaults%3DW3sidmFsdWUiOiJ7XG4gIFwicGVybWlzc2lvbnNcIjoge1xuICAgIFwiYWxsb3dcIjogW1xuICAgICAgXCJCYXNoKC4vZ3JhZGxldzoqKVwiLFxuICAgICAgXCJCYXNoKGNhdDoqKVwiLFxuICAgICAgXCJCYXNoKGVjaG86KilcIixcbiAgICAgIFwiQmFzaChmaW5kOiopXCIsXG4gICAgICBcIkJhc2goZ2g6KilcIixcbiAgICAgIFwiQmFzaChnaXQ6KilcIixcbiAgICAgIFwiQmFzaChncmVwOiopXCIsXG4gICAgICBcIkJhc2goamF2YWM6KilcIixcbiAgICAgIFwiQmFzaChtdjoqKVwiLFxuICAgICAgXCJCYXNoKG5wbSB0ZXN0OiopXCIsXG4gICAgICBcIkJhc2gocmc6KilcIixcbiAgICAgIFwiQmFzaChybToqKVwiLFxuICAgICAgXCJCYXNoKHRpbWVvdXQ6KilcIixcbiAgICAgIFwiV2ViRmV0Y2goZG9tYWluOmdpdGh1Yi5jb20pXCIsXG4gICAgICBcIm1jcF9fZ2l0aHViX19nZXRfaXNzdWVcIixcbiAgICAgIFwibWNwX19naXRodWJfX2dldF9pc3N1ZV9jb21tZW50c1wiLFxuICAgICAgXCJtY3BfX2dpdGh1Yl9fZ2V0X3B1bGxfcmVxdWVzdFwiLFxuICAgICAgXCJtY3BfX2dpdGh1Yl9fZ2V0X3B1bGxfcmVxdWVzdF9jb21tZW50c1wiLFxuICAgICAgXCJtY3BfX2lkZWFfX2ZpbmRfZmlsZXNfYnlfbmFtZV9zdWJzdHJpbmdcIixcbiAgICAgIFwibWNwX19pZGVhX19nZXRfZmlsZV90ZXh0X2J5X3BhdGhcIixcbiAgICAgIFwibWNwX19pZGVhX19nZXRfb3Blbl9pbl9lZGl0b3JfZmlsZV9wYXRoXCIsXG4gICAgICBcIm1jcF9faWRlYV9fZ2V0X29wZW5faW5fZWRpdG9yX2ZpbGVfdGV4dFwiLFxuICAgICAgXCJtY3BfX2lkZWFfX2dldF9zZWxlY3RlZF9pbl9lZGl0b3JfdGV4dFwiLFxuICAgICAgXCJtY3BfX2lkZWFfX2xpc3RfZGlyZWN0b3J5X3RyZWVfaW5fZm9sZGVyXCIsXG4gICAgICBcIm1jcF9faWRlYV9fbGlzdF9maWxlc19pbl9mb2xkZXJcIixcbiAgICAgIFwibWNwX19pZGVhX19vcGVuX2ZpbGVfaW5fZWRpdG9yXCIsXG4gICAgICBcIm1jcF9faWRlYV9fcmVwbGFjZV9zZWxlY3RlZF90ZXh0XCIsXG4gICAgICBcIm1jcF9faWRlYV9fcmVwbGFjZV9zcGVjaWZpY190ZXh0XCIsXG4gICAgICBcIm1jcF9faWRlYV9fc2VhcmNoX2luX2ZpbGVzX2NvbnRlbnRcIlxuICAgIF0sXG4gICAgXCJkZW55XCI6IFtdXG4gIH1cbn1cbiIsIm5hbWUiOiJmaWxlQ29udGVudHMifSx7InZhbHVlIjoiLmNsYXVkZS9zZXR0aW5ncy5sb2NhbC5qc29uIiwibmFtZSI6InJlbGF0aXZlRmlsZU5hbWUifSx7InZhbHVlIjpmYWxzZSwibmFtZSI6Im92ZXJ3cml0ZUV4aXN0aW5nIn1d

Co-authored-by: Moderne <[email protected]>
    @greg-at-moderne @TeamModerne
    greg-at-moderne and TeamModerne committed Aug 4, 2025
    Configuration menu
    Copy the full SHA
    bb34ecf View commit details
    Browse the repository at this point in the history

  2. Add ArgumentArrayToVarargs for logger methods that take a var args … 

    …argument Object array (#246)

* Add start for converting Object[] to ...

* Implement ArgumentArrayToVarargs

* Add recipe to new JBossLoggingBestPractices

* Add a case that should not be converted

* Only convert when the method type has varargs flag set

* Minor fixes and add to Slf4J best practices too

* Update ArgumentArrayToVarargs.java

* JulParameterizedArguments reuses ArgumentArrayToVarargs

* Remove now unused methods

* Slight polish

---------

Co-authored-by: Pierre Delagrave <[email protected]>
    @timtebeek @pdelagrave
    timtebeek and pdelagrave authored Aug 4, 2025
    Configuration menu
    Copy the full SHA
    249944e View commit details
    Browse the repository at this point in the history

  3. Avoid unsafe changes in JulParameterizedArguments when `JavaType.Ar… 

    …ray` argument is not a `J.NewArray` (#244)

* support migrating `JUL.log("{0}", arrayIdentifier)` to slf4j

* applied multiple review suggestions

* Use static import for Collections

* Apply suggestions from code review

* Revert the array unpacking improvement

First time testing for a negative case shows that the recipe isn't producing valid code by itself and that `org.openrewrite.java.logging.slf4j.JulToSlf4j` isn't either. Fixed in the next commit.

* Skip `JulParameterizedArguments` to avoid unsafe change there

---------

Co-authored-by: Tim te Beek <[email protected]>
    @pdelagrave @timtebeek
    pdelagrave and timtebeek authored Aug 4, 2025
    Configuration menu
    Copy the full SHA
    aa3f14f View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2025

  1. OpenRewrite recipe best practices 

    Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.recipes.rewrite.OpenRewriteRecipeBestPractices?organizationId=QUxML09wZW4gU291cmNlL09wZW5SZXdyaXRl

Co-authored-by: Moderne <[email protected]>
    @timtebeek @TeamModerne
    timtebeek and TeamModerne committed Aug 5, 2025
    Configuration menu
    Copy the full SHA
    36a5200 View commit details
    Browse the repository at this point in the history

  2. LoggerLevelArgumentToMethod for JBoss Logging (#243) 

    * LoggerLevelArgumentToMethod for JBoss Logging

* Fixes from review

* Polish

* Add package-info

* Polish

* Add to best practices already

* Create a separate test for documentation purposes

* Add recipe examples documentation

Added example documentation for the following recipes:
- ArgumentArrayToVarargs
- FormattedArgumentsToVMethodRecipes (JBoss)
- JBossLoggingBestPractices
- LoggerLevelArgumentToMethod (JBoss)

These examples demonstrate the transformations performed by each recipe.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>

* Don't change if we can not determine level

* Only transfer the whitespace from the first argument

---------

Co-authored-by: lingenj <[email protected]>
Co-authored-by: Tim te Beek <[email protected]>
Co-authored-by: Claude <[email protected]>
    @pdelagrave @jevanlingen
    @timtebeek @claude
    4 people authored Aug 5, 2025
    Configuration menu
    Copy the full SHA
    c59c405 View commit details
    Browse the repository at this point in the history

  3. Add a recipe to migrate from JBoss Logging to SLF4J (#241) 

    * dependencies

* Simple logger invocations

* Minimize modifiers in tests

* Minimize test using AssertJ's `actual()`

* Inline `JBossLoggingToSlf4jUpdateDependencies` and run best practices before migration

* Simplify tests

---------

Co-authored-by: Tim te Beek <[email protected]>
    @pdelagrave @timtebeek
    pdelagrave and timtebeek authored Aug 5, 2025
    Configuration menu
    Copy the full SHA
    2e67627 View commit details
    Browse the repository at this point in the history

  4. rename settings.local.json to settings.json (#247) 

    Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.RenameFile?organizationId=QUxML09wZW4gU291cmNlL09wZW5SZXdyaXRl#defaults%3DW3sidmFsdWUiOiIuY2xhdWRlL3NldHRpbmdzLmxvY2FsLmpzb24iLCJuYW1lIjoiZmlsZU1hdGNoZXIifSx7InZhbHVlIjoic2V0dGluZ3MuanNvbiIsIm5hbWUiOiJmaWxlTmFtZSJ9XQ%3D%3D

Co-authored-by: Moderne <[email protected]>
    @zieka @TeamModerne
    zieka and TeamModerne authored Aug 5, 2025
    Configuration menu
    Copy the full SHA
    210eff9 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2025

  1. Update documentation examples 

    Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.recipes.rewrite.OpenRewriteRecipeBestPractices?organizationId=QUxML09wZW4gU291cmNlL09wZW5SZXdyaXRl

Co-authored-by: Moderne <[email protected]>
    @timtebeek @TeamModerne
    timtebeek and TeamModerne committed Aug 7, 2025
    Configuration menu
    Copy the full SHA
    946d0ce View commit details
    Browse the repository at this point in the history
Loading