Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: openrewrite/rewrite-logging-frameworks
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v3.10.0
Choose a base ref
...
head repository: openrewrite/rewrite-logging-frameworks
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v3.11.0
Choose a head ref
  • 11 commits
  • 31 files changed
  • 9 contributors

Commits on Jun 26, 2025

  1. Remove uses of J.MethodInvocation#withDeclaringType() 

    This method doesn't add any real value.
    @knutwannheden
    knutwannheden committed Jun 26, 2025
    Configuration menu
    Copy the full SHA
    6d64cce View commit details
    Browse the repository at this point in the history

  2. fix: any last argument matching Throwable.toString() is left as is (#… 

    …229)c

In SLF4J, the last argument of the logging methods will be treated specially and removed from the formatted string argument array if it's a Throwable.

When the last argument was a `.toString()` call we stripped it even if it was a `Throwable` which changed the behaviour.

https://www.slf4j.org/faq.html#paramException
    @pdelagrave
    pdelagrave authored Jun 26, 2025
    Configuration menu
    Copy the full SHA
    1aa3952 View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2025

  1. Pin JUnit to 5.+ 

    Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.text.FindAndReplace?organizationId=ODQ2MGExMTUtNDg0My00N2EwLTgzMGMtNGE1NGExMTBmZDkw#defaults%3DW3sidmFsdWUiOiI6anVuaXQtKC4qKTpsYXRlc3QucmVsZWFzZSIsIm5hbWUiOiJmaW5kIn0seyJ2YWx1ZSI6IjpqdW5pdC0kMTo1LisiLCJuYW1lIjoicmVwbGFjZSJ9LHsidmFsdWUiOiJUcnVlIiwibmFtZSI6InJlZ2V4In0seyJ2YWx1ZSI6ImJ1aWxkLmdyYWRsZS5rdHMiLCJuYW1lIjoiZmlsZVBhdHRlcm4ifV0%3D

Co-authored-by: Moderne <[email protected]>
    @timtebeek @TeamModerne
    timtebeek and TeamModerne committed Jun 27, 2025
    Configuration menu
    Copy the full SHA
    62605ca View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2025

  1. refactor: org.openrewrite.mavencentral (#230) 

    Use this link to re-run the recipe: https://app.moderne.io/builder/zYwEKw0Gm?organizationId=QUxML09wZW4gU291cmNlL09wZW5SZXdyaXRl

Co-authored-by: Moderne <[email protected]>
    @Laurens-W @TeamModerne
    Laurens-W and TeamModerne authored Jul 2, 2025
    Configuration menu
    Copy the full SHA
    01ed581 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2025

  1. refactor: Remove out-of-date OWASP suppressions 

    Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.xml.security.RemoveOwaspSuppressions?organizationId=QUxML09wZW4gU291cmNlL09wZW5SZXdyaXRl#defaults%3DW3sidmFsdWUiOiIyMDI1LTA2LTMwIiwibmFtZSI6ImN1dE9mZkRhdGUifV0%3D

Co-authored-by: Moderne <[email protected]>
    @Laurens-W @TeamModerne
    Laurens-W and TeamModerne committed Jul 3, 2025
    Configuration menu
    Copy the full SHA
    732de8c View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2025

  1. refactor: Update Gradle wrapper 

    Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.gradle.UpdateGradleWrapper?organizationId=QUxML09wZW4gU291cmNlL09wZW5SZXdyaXRl#defaults%3DW3sidmFsdWUiOmZhbHNlLCJuYW1lIjoiYWRkSWZNaXNzaW5nIn1d

Co-authored-by: Moderne <[email protected]>
    @shanman190 @TeamModerne
    shanman190 and TeamModerne committed Jul 4, 2025
    Configuration menu
    Copy the full SHA
    512ccc6 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2025

  1. Avoid -SNAPSHOT versions of JUnit 5.+ 

    Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.text.FindAndReplace?organizationId=ODQ2MGExMTUtNDg0My00N2EwLTgzMGMtNGE1NGExMTBmZDkw#defaults%3DW3sibmFtZSI6ImZpbmQiLCJ2YWx1ZSI6Imp1bml0LWp1cGl0ZXItZW5naW5lOjUuKyJ9LHsibmFtZSI6InJlcGxhY2UiLCJ2YWx1ZSI6Imp1bml0LWp1cGl0ZXItZW5naW5lOjUuMTMuMyJ9LHsibmFtZSI6ImZpbGVQYXR0ZXJuIiwidmFsdWUiOiIqKi9idWlsZC5ncmFkbGUua3RzIn1d

Co-authored-by: Moderne <[email protected]>
    @timtebeek @TeamModerne
    timtebeek and TeamModerne committed Jul 5, 2025
    Configuration menu
    Copy the full SHA
    a737fc5 View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2025

  1. refactor: Reorder annotations alphabetically 

    Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.staticanalysis.ReorderAnnotations?organizationId=QUxML09wZW4gU291cmNlL09wZW5SZXdyaXRl

Co-authored-by: Moderne <[email protected]>
    @timtebeek @TeamModerne
    2 people authored and app committed Jul 7, 2025
    Configuration menu
    Copy the full SHA
    ce62f40 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2025

  1. Don't if-wrap logs when arguments are getters (#233) 

    * tests: Don't if-wrap logs when args are getters

* more and better tests
started to implement

* Update src/main/java/org/openrewrite/java/logging/slf4j/WrapExpensiveLogStatementsInConditionals.java

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update src/main/java/org/openrewrite/java/logging/slf4j/WrapExpensiveLogStatementsInConditionals.java

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* implemented more
added more tests

* clean up

* Adopt `@ValueSource(strings = {...})` for simplicity

* Illustrate a case missed so far

* Minor changes

* Fixed test

* Condense logic

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Tim te Beek <[email protected]>
    @pdelagrave @github-actions @timtebeek
    3 people authored Jul 8, 2025
    Configuration menu
    Copy the full SHA
    5ca86c6 View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2025

  1. refactor: Remove redundant null checks before instanceof 

    Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.staticanalysis.RemoveRedundantNullCheckBeforeInstanceof?organizationId=ODQ2MGExMTUtNDg0My00N2EwLTgzMGMtNGE1NGExMTBmZDkw

Co-authored-by: Moderne <[email protected]>
    @timtebeek @TeamModerne
    timtebeek and TeamModerne committed Jul 9, 2025
    Configuration menu
    Copy the full SHA
    4e96d7b View commit details
    Browse the repository at this point in the history

  2. refactor: OpenRewrite Recipe best practices 

    Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.recipes.rewrite.OpenRewriteRecipeBestPractices?organizationId=QUxML09wZW4gU291cmNlL09wZW5SZXdyaXRl

Co-authored-by: Moderne <[email protected]>
    @timtebeek @TeamModerne
    2 people authored and app committed Jul 9, 2025
    Configuration menu
    Copy the full SHA
    d214405 View commit details
    Browse the repository at this point in the history
Loading