Skip to content

Reject SNAPSHOT versions in parser classpath dependencies#155

Closed
timtebeek wants to merge 1 commit intomainfrom
timtebeek/reject-snapshots
Closed

Reject SNAPSHOT versions in parser classpath dependencies#155
timtebeek wants to merge 1 commit intomainfrom
timtebeek/reject-snapshots

Conversation

@timtebeek
Copy link
Copy Markdown
Member

Add a component selection rule that rejects SNAPSHOT versions when resolving parser classpath dependencies to ensure only stable releases are used.

The change extracts the detached configuration into a variable and applies a component selection rule that rejects any version containing "SNAPSHOT".

Add a component selection rule that rejects SNAPSHOT versions when resolving parser classpath dependencies to ensure only stable releases are used.
@github-project-automation github-project-automation Bot moved this to In Progress in OpenRewrite Feb 21, 2026
@timtebeek timtebeek marked this pull request as ready for review February 22, 2026 12:33
@timtebeek timtebeek requested a review from shanman190 February 22, 2026 12:33
@timtebeek timtebeek moved this from In Progress to Ready to Review in OpenRewrite Feb 22, 2026
@timtebeek timtebeek added the enhancement New feature or request label Feb 22, 2026
Copy link
Copy Markdown
Contributor

@shanman190 shanman190 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are sometime valid uses for using snapshot dependencies. One example that comes to mind is how we try to get community authors to write recipes to help their users migrate to new versions. It's most desirable for that to happen on the inner development loop.

I feel like this is now begging the question of if type tables should be a generated resource as part of the build rather than a committed one. As a consequence, this sort of problem would disappear due to our -Preleasing=true flag.

@timtebeek
Copy link
Copy Markdown
Member Author

Hmm; what prompted this was some flakiness in rewrite-testing-frameworks, because the 3.+ used there picks up snapshots, which are now pinned after

I'm fine not to adopt this change, but I'd myself still lean towards using exact versions in type tables and check those in, since they wouldn't change unless entries are added/removed. That also makes our builds a little more reproducible, especially when new versions come out often.

@timtebeek timtebeek closed this Feb 22, 2026
@github-project-automation github-project-automation Bot moved this from Ready to Review to Done in OpenRewrite Feb 22, 2026
@timtebeek timtebeek deleted the timtebeek/reject-snapshots branch February 22, 2026 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants