Enhance AddImport to shorten fully qualified names#5452
Merged
Conversation
This was referenced May 19, 2025
timtebeek
approved these changes
May 19, 2025
timtebeek
left a comment
timtebeek
left a comment
Member
There was a problem hiding this comment.
Thanks for the quick fixes here and downstream in openrewrite/rewrite-testing-frameworks#731; great to roll forwards.
github-project-automation
Bot
moved this from In Progress
to Ready to Review
in OpenRewrite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changed?
PR #5439 introduced logic to handle import ambiguity by using fully qualified names when conflicting usages are present. However, this led to regressions in cases where such conflicts only existed temporarily during multi-step recipe transformations.
Issue
When multiple recipes are applied, intermediate steps may introduce conflicting usages. But at the end might all such usage can be safely replaced to shortend names.
To handle this, updated AddImport to shorten existing fullyqualified names for the type or member for which import is being added.
Testing
Validated the fix by running all tests in the rewrite-testing-frameworks.
Checklist