support to add relative path dynamic-module in configure#343
Closed
catatsuy wants to merge 2 commits intoopenresty:masterfrom
Closed
support to add relative path dynamic-module in configure#343catatsuy wants to merge 2 commits intoopenresty:masterfrom
catatsuy wants to merge 2 commits intoopenresty:masterfrom
Conversation
Member
|
@catatsuy Looking good to me. Mind to add a test case to the existing test suite to cover this new feature? Thanks! |
Contributor
Author
|
@agentzh I added a test. Please check. |
|
@agentzh Hello, I would like to translate to Spanish but I do not know how. I would like to do it by means of pull request :) |
Member
|
@shadowz10 Please do not hijack unrelated PRs or issues. Thank you. |
Member
|
@catatsuy Sorry for the delay on my side. Just merged it with fixes for the test failures. |
Member
|
Thanks! |
Contributor
Author
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby granted the copyright of the changes in this pull request
to the authors of this openresty project.