bugfix: revert #2174 and #2237 due to http2 behavior break change#2286
Closed
oowl wants to merge 6 commits into
Closed
bugfix: revert #2174 and #2237 due to http2 behavior break change#2286oowl wants to merge 6 commits into
oowl wants to merge 6 commits into
Conversation
oowl
changed the title
Member
|
Could you also add document for the behavior of client_max_body_size and client_body_timeout and their effect on |
Contributor
Author
On the way |
…HTTP3 processing case
oowl
changed the title
3 tasks
dndx
requested changes
Feb 28, 2024
dndx
left a comment
dndx
left a comment
Member
There was a problem hiding this comment.
We do not need to mention gRPC specifically, the read time out and body size limit applies to all HTTP versions.
dndx
requested changes
Feb 28, 2024
dndx
requested changes
Feb 28, 2024
oowl
force-pushed
the
revert-req-body
branch
from
February 28, 2024 07:19
ab06340 to
d7d6b5a
Compare
dndx
previously approved these changes
Feb 28, 2024
Contributor
Author
|
@zhuizhuhaomeng @swananan Hi, Can you help me to review this? |
swananan
approved these changes
Feb 28, 2024
dndx
pushed a commit
to Kong/kong
that referenced
this pull request
Feb 29, 2024
…oding limitation (#12658) Cherry picked from openresty/lua-nginx-module#2286. It was acknowledged by OpenResty as a mistaken breaking change, and we should revert it. FTI-5766 FTI-5795
github-actions Bot
pushed a commit
to Kong/kong
that referenced
this pull request
Feb 29, 2024
…oding limitation (#12658) Cherry picked from openresty/lua-nginx-module#2286. It was acknowledged by OpenResty as a mistaken breaking change, and we should revert it. FTI-5766 FTI-5795 (cherry picked from commit 55358df)
3 tasks
| repeat_each(2); | ||
|
|
||
| plan tests => repeat_each() * (blocks() * 4 + 56); | ||
| plan tests => repeat_each() * (blocks() * 4 + 58 ); |
Contributor
There was a problem hiding this comment.
An extra space, I will remove it on merging.
zhuizhuhaomeng
dismissed
dndx’s stale review
March 1, 2024 00:58
The merge-base changed after approval.
|
This pull request is now in conflict :( |
Contributor
|
I have merged this PR with a small modification. |
windmgc
pushed a commit
to Kong/kong
that referenced
this pull request
Mar 1, 2024
…oding limitation (#12658) Cherry picked from openresty/lua-nginx-module#2286. It was acknowledged by OpenResty as a mistaken breaking change, and we should revert it. FTI-5766 FTI-5795 (cherry picked from commit 55358df)
ogercyprien
added a commit
to opendatasoft/lua-resty-waf
that referenced
this pull request
Aug 26, 2024
In lua-nginx-module, the changed introduced in PR #2237, which required an adpatation in lua-resty-waf in commi be3428d, was reverted. See openresty/lua-nginx-module#2286
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
revert #2174 and #2237 due to http2 behavior break change, context: #2211
I hereby granted the copyright of the changes in this pull request
to the authors of this lua-nginx-module project.