bugfix: disable http2 in body read due to http2 stream processing bug#2174
Merged
zhuizhuhaomeng merged 8 commits intoMay 11, 2023
Merged
Conversation
Contributor
Author
|
PR context #2172 |
oowl
force-pushed
the
fix/read_body_api_http2_disable
branch
from
March 29, 2023 03:16
b30c569 to
a411a42
Compare
Contributor
Author
|
I don't know how to test this, because |
oowl
changed the title
Contributor
Author
|
@zhuizhuhaomeng Hi, Can you help me review this PR? |
zhuizhuhaomeng
requested changes
Apr 3, 2023
Contributor
|
we need to add test cases for this PR @attenuation |
Contributor
Author
|
@zhuizhuhaomeng Can you take a look of this PR? |
Co-authored-by: lijunlong <[email protected]>
Co-authored-by: lijunlong <[email protected]>
Co-authored-by: lijunlong <[email protected]>
Contributor
Author
|
@zhuizhuhaomeng Hi, Can you help me look at this PR again? |
zhuizhuhaomeng
requested changes
May 10, 2023
oowl
force-pushed
the
fix/read_body_api_http2_disable
branch
from
May 10, 2023 14:44
d08da97 to
54c5762
Compare
zhuizhuhaomeng
approved these changes
May 11, 2023
Appla
reviewed
Sep 15, 2023
|
|
||
| /* http2 read body may break http2 stream process */ | ||
| #if (NGX_HTTP_V2) | ||
| if (r->main->stream) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby granted the copyright of the changes in this pull request
to the authors of this lua-nginx-module project.