Conversation
- Add form request to additionalteam and Analysis Controller. - Consistent routing with codebooks - Use patch route to update codebook
- created factory of codebooks - used the request validation instead of the inline one for the codebook controller and codebookcodes controller - extended tests for codebooks
- coding controller has now security checks - add codecontrollertests - optimized the code update to just one function instead of 3
- now the project controller is refactored - still need to refactor the audits - removed unused or useless code - new requests for resources
- removed description limit
added 3 commits
September 12, 2024 10:53
- now audits have their controller - url consistency
- add form request and security to the selection controller
…nto refactor/client-components
- now we add a codebook property "code order" - implemented tests for that - improved codebook update to include code_order - improved form request to include codebook update
…actor/client-components
- we can now store settings in the settings table - created allowed settings table, currently not used but ready for - created migrations, tests, factories and enum - created command to manage allowed settings
…actor/client-components
- rename from default codebook to "project name codebook" - bugifx export codebook - add tests for new features
…actor/client-components
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor using Backend refactor guidelines.
Implement Form Requests:
Review and Refactor Models:
$fillable,$timestamps,$primaryKey,$auditExclude,$castsand other properties correctly.Review and Refactor Controllers:
index,show,store,update,destroy) when possible.Optimize Database Interactions:
Review and Improve Policies:
app/Policies.