Bugfix: send navigation updates only when in a team#53
Merged
jankapunkt merged 1 commit intomainfrom Jun 28, 2024
Merged
Conversation
- Add check for non-empty sharedTeam object in onMounted - this means that we send the updates to the presence only if the user is in a team inside a project
jankapunkt
approved these changes
Jun 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The check if the user was in a team or not was bugged, now we're sending navigation updates only when a user is in a team.
To verify it, check https://stagingqda.uni-bremen.de/ in a non-shared project, you should not see the "navigation" endpoint being called every 5 seconds.
Check also offline, in another branch, you should see the call happening, along with some weird errors.