Merged
Conversation
added 2 commits
May 22, 2024 15:06
using laravel pint as linter
Member
|
@alessandrobelli awesome! It already runs in this pr, see the checks section. Note that it's failing. If you want I can merge and you address the lint errors later or you can add fixes to this PR. To me both are okay |
added 3 commits
May 23, 2024 10:11
- now the github action just check the code style and there's a pre-commit action to actually format the code
- run laravel pint just by tipying "pint" in your terminal
Contributor
Author
|
@jankapunkt changed it, the linter is pint, and we just need to type |
jankapunkt
previously approved these changes
May 25, 2024
Member
|
@alessandrobelli please adress my question and resolve the conversation if you think it's not necessary, then I will merge it. |
jankapunkt
approved these changes
May 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
it executes every push or pull request and address #5
@jankapunkt will it execute on my request or on merge?