Skip to content

Comments

Feature: client test suite#25

Merged
jankapunkt merged 12 commits intomainfrom
feature/tests-client
Jun 6, 2024
Merged

Feature: client test suite#25
jankapunkt merged 12 commits intomainfrom
feature/tests-client

Conversation

@jankapunkt
Copy link
Member

This adds basic unit tests (via vitest) and e2e tests (via cypress) to the client.

@jankapunkt jankapunkt added this to the Pre-Release milestone May 17, 2024
@jankapunkt jankapunkt marked this pull request as ready for review May 21, 2024 08:25
@alessandrobelli
Copy link
Contributor

Is there a quick way for me to test this?

We should add a testing documentation, it can even be extremely short, such as "to run frontend test run this command ..." - "to run backend test run this command ...".

@jankapunkt
Copy link
Member Author

@alessandrobelli you're absolutely right about this, I added a testing guide to the docs. You should be able to reproduce everything using the guide.

@jankapunkt
Copy link
Member Author

@alessandrobelli could you please check this again, I have added a testing guide already :-)

@jankapunkt jankapunkt self-assigned this May 25, 2024
@alessandrobelli
Copy link
Contributor

Also I get this when running unit tests:

⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯ Unhandled Error ⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯
Error: Cannot find module @rollup/rollup-darwin-arm64. npm has a bug related to optional dependencies (https://github.com/npm/cli/issues/4828). Please try `npm i` again after removing both package-lock.json and node_modules directory.

But this might be just a node problem. After I deleted node modules and installed again, it worked.

@jankapunkt
Copy link
Member Author

@alessandrobelli I removed e2e for now as we have some full-stack tests already with pest and the e2e make more sense, once we have the new design and layout implemented.

Copy link
Contributor

@alessandrobelli alessandrobelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

npx cypress open --env host=web.test is running, but I can't see anything, as for the comment #25 (comment) .
Maybe it's on my end, anyway I will approve

@jankapunkt jankapunkt merged commit 6860f08 into main Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants