Fix arbitrary file read vulnerability in CodingController and SourceController#219
Merged
jankapunkt merged 4 commits intofix/team-invitationfrom Dec 5, 2025
Merged
Conversation
…roller and SourceController Co-authored-by: jankapunkt <[email protected]>
…ation security Co-authored-by: jankapunkt <[email protected]>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] WIP address feedback on team invitation and notification implementation
Fix arbitrary file read vulnerability in CodingController and SourceController
Dec 2, 2025
Member
|
@copilot you forgot to update the tests in tests/Feature/SourceControllerTest.php as they now throw an error: Failed asserting that an array has the subset Array &0 [
at tests/Feature/SourceControllerTest.php:190 |
…dation Co-authored-by: jankapunkt <[email protected]>
Contributor
Author
Fixed in commit 7233410. The |
jankapunkt
added a commit
that referenced
this pull request
Dec 15, 2025
* ci: add npm audit for production deps to ci * build(deps): fix known production vulnerabilities / npm audit fix * fix(backend/ui): Coding page displays empty page when no source was selected * feature: team invitation email to join the team * feature: use .env to configure invitation or direct adding team members * fix: added tests and guard clauses * fix(tests): update edge cases in tests * fix(tests): fix test error * fix: tests fixed * fix: update tests * tests: stub env for other tests in InviteTeamMemberTest * fix: use correct assertion * fix: inivitation tests * fix: tests * fix(tests): run local tests with laravel sail * fix: laravel pint fix * Fix arbitrary file read vulnerability in CodingController and SourceController (#219) * Initial plan * fix: add path validation to prevent arbitrary file read in CodingController and SourceController Co-authored-by: jankapunkt <[email protected]> * refactor: extract validateStoragePath to trait and improve path validation security Co-authored-by: jankapunkt <[email protected]> * fix: create test file in test_update_source_content to pass path validation Co-authored-by: jankapunkt <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: jankapunkt <[email protected]> --------- Co-authored-by: Copilot <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
validateStoragePath()to a reusableValidatesStoragePathtraitstr_starts_with()instead ofstrpos()for clearer intentSecurity Summary
The original code in
CodingController.phpandSourceController.phpcontained a potential arbitrary file read vulnerability wherefile_get_contents($source->converted->path)read a file path from database/model data without validation. An attacker who could influence theSource->converted->pathvalue could potentially read sensitive server files.Fix: Added
ValidatesStoragePathtrait withvalidateStoragePath()method that:realpath()to resolve the actual file path (handles symlinks and..components)str_starts_with()with trailing directory separator to ensure the path is strictly within thestorage/app/projectsdirectory💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.