Merged
Conversation
Closed
6 tasks
Member
Author
|
@alessandrobelli I finally managed to fix all linter issues. However since we have no tests yet we need to carefully check, whether things still work as expected. From what I see it's urgent to setup tests as a next step. |
alessandrobelli
requested changes
May 16, 2024
Contributor
alessandrobelli
left a comment
alessandrobelli
left a comment
There was a problem hiding this comment.
There's a new error in the preparation page. To recreate, click on "new file", the new file is not shown.
I tested the main branch and the error is not there.
Member
Author
|
Thanks for the hint @alessandrobelli this was a negative side effect because before, it worked but it was mutating props which we should not do and the linter errors on that. I have to rewrite the comoponents to work but not mutate props. |
alessandrobelli
approved these changes
May 17, 2024
Contributor
alessandrobelli
left a comment
alessandrobelli
left a comment
There was a problem hiding this comment.
Quickly tested offline and it worked
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the following features to the client side of the project:
additionally, all code is