adjust expected performance for intersection calcuations#165
Merged
jankapunkt merged 1 commit intomainfrom Jul 2, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adjusts the expected performance thresholds for intersection calculations to reduce CI test flakiness while acknowledging the exponential scaling of the function.
- Increased the allowed execution time for a small set of selections from 10ms to 50ms.
- Increased the allowed execution time for a larger set of selections from 100ms to 1000ms.
alessandrobelli
approved these changes
Jul 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The client tests CI often fails due to very restrictive expected performance of intersection computation.
This PR increases the expected amount of time to yet agreeable values, respecting the fact that this fn currently scales exponentially.