Skip to content

Comments

Feature: embedded experience feedback#113

Merged
jankapunkt merged 13 commits intomainfrom
feature/embedded-experience-feedback
Sep 15, 2025
Merged

Feature: embedded experience feedback#113
jankapunkt merged 13 commits intomainfrom
feature/embedded-experience-feedback

Conversation

@jankapunkt
Copy link
Member

@jankapunkt jankapunkt commented Mar 12, 2025

This is a work in progress!

Implements #104 as global dialog that is aware of the current page context.

  • help dialog with basic form
  • client validation for form
  • server endpoint to receive and validate the form
  • send email to receivers, defined in .env

@jankapunkt jankapunkt linked an issue Mar 12, 2025 that may be closed by this pull request
@jankapunkt jankapunkt added this to the 1.1.0 milestone Mar 13, 2025
@jankapunkt jankapunkt marked this pull request as ready for review September 1, 2025 10:59
@jankapunkt jankapunkt requested a review from Copilot September 1, 2025 10:59
@jankapunkt jankapunkt self-assigned this Sep 1, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements a feedback dialog system for embedded experience feedback functionality, adding a global dialog that is aware of current page context. The implementation includes a help dialog with form handling, submission status management, and email notifications.

  • Dialog-based feedback form with type selection (help, bug report, feedback)
  • Email system improvements with ticket ID generation and updated template structure
  • Form component styling updates and composable utilities for status management

Reviewed Changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
web/resources/views/emails/user-feedback.blade.php Updates email template to include new fields like type, path, query, and confirmation preferences
web/resources/js/form/TextArea.vue Refactors styling to use utility function and updates focus states
web/resources/js/form/Checkbox.vue Adds styling improvements and margin adjustments
web/resources/js/domain/project/useProjects.js Exposes projectId and renames parameter to avoid shadowing
web/resources/js/dialogs/useSubmissionStatus.js New composable for managing form submission states
web/resources/js/dialogs/help/useHelpDialog.js New composable for help dialog state and API submission
web/resources/js/dialogs/help/HelpDialog.vue Main dialog component with form schema and submission logic
web/resources/js/dialogs/DialogBase.vue Adds static prop to prevent accidental closing
web/resources/js/Layouts/AuthenticatedLayout.vue Integrates help dialog button and component
web/app/Mail/UserFeedback.php Updates constructor and envelope to support ticket IDs
web/app/Http/Requests/SendFeedbackRequest.php Updates validation rules for new form fields
web/app/Http/Controllers/UserNavigationController.php Adds logging and ticket ID generation

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

kadewe
kadewe previously approved these changes Sep 12, 2025
@jankapunkt
Copy link
Member Author

Please do one last check and approve if this can be meged

Copy link
Contributor

@kadewe kadewe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, tested it, all links to doc and discussion are ok!

@jankapunkt jankapunkt merged commit a7d081d into main Sep 15, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Builtin report component

2 participants