Fix: preserve whitespace and fonts across editors#111
Merged
jankapunkt merged 1 commit intomainfrom Mar 11, 2025
Merged
Conversation
kadewe
approved these changes
Mar 10, 2025
Contributor
kadewe
left a comment
kadewe
left a comment
There was a problem hiding this comment.
Looks good to me, the content hash is a good idea. We need to explain it in the docs!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix attempts to address #110 by ensuring to save semantic HTML from editor which contains explicit whitespace characters. Furthermore, fonts are now saved, due to a workaround, as Quill does not correctly register fonts, comprising of multiple words (such as "courier-new").
Finally, editors now generate a hash-sum to allow users inspect content integrity (there are more use cases to it but thats beyond scope of this fix), which also showed a mismatch between preparations-editor and coding-editor, which is also now fixed by using the exact same formatting modules for quill on both.
Note, the integrity of the source is not affected by selections during coding:
Preparations Editor
Coding Editor
Edit: please no hate against comic sans! 🤡