Fix zlib compression for data larger than 65KB #1894
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Regression introduced in openpgpjs#1826 (v6.2.0) . Due to internal fflate lib changes, part of the compressed data ended up being discarded, leading to a corrupted compressed payload for the encrypted/signed message, which cannot be decompressed. Compression is disabled by default in openpgpjs. Hence, the issue affects only users who enabled zlib compression via e.g. `config.preferredCompressionAlgorithm = openpgp.enums.compression.zlib` and encrypted or signed data larger than 65KB.
larabr
force-pushed
the
fix/fflate-v8-zlib-corruption
branch
from
cb3a8b7 to
0ab548c
Compare
twiss
approved these changes
Sep 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression introduced in #1826 (v6.2.0) .
Due to internal fflate lib changes , part of the compressed data ended up being discarded, leading to a corrupted compressed payload for the encrypted/signed message, which cannot be decompressed.
Compression is disabled by default in openpgpjs.
Hence, the issue affects only users who enabled zlib compression via e.g.
config.preferredCompressionAlgorithm = openpgp.enums.compression.zliband encrypted or signed data larger than 65KB.