[v6] read[Private]Key: support parsing key blocks (return first parsable key)
#1755
+78
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…public keys Previously, parsing a key block where a public key followed a private one would fail.
… key) Previously, `readKey` and `readPrivateKey` would throw when given a block of keys as input. With this change, the first parsable key is returned by both functions: the behaviour is equivalent to calling `readKeys` (resp. `readPrivateKeys`) and taking the first array entry.
twiss
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
readKeyandreadPrivateKeywould throw when given a block of keys as input.With this change, the first parsable key is returned by both functions:
the behaviour is equivalent to calling
readKeys(resp.readPrivateKeys) and taking the first array entry.Also,
readPrivateKeysnow supports parsing key blocks with mix of private and public keys (previously, parsing a key block where a public key followed a private one would fail).