[v6] Disregard config.aeadProtect when encrypting to public keys
#1678
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Determine whether AEAD should be used for encryption solely based the encryption key preferences. Previously, the config flag was also used to control the behaviour, since AEAD messages were not standardised nor widely supported. To generate keys that declare AEAD in their preferences, use `generateKey` with `config.aeadProtect = true`.
twiss
approved these changes
Oct 17, 2023
Co-authored-by: Daniel Huigens <[email protected]>
larabr
added a commit
that referenced
this pull request
Oct 20, 2023
Determine whether AEAD should be used for encryption solely based the encryption key preferences. Previously, the config flag was also used to control the behaviour, since AEAD messages were not standardised nor widely supported. To generate keys that declare AEAD in their preferences, use `generateKey` with `config.aeadProtect = true`.
larabr
added a commit
that referenced
this pull request
Oct 24, 2023
Determine whether AEAD should be used for encryption solely based the encryption key preferences. Previously, the config flag was also used to control the behaviour, since AEAD messages were not standardised nor widely supported. To generate keys that declare AEAD in their preferences, use `generateKey` with `config.aeadProtect = true`.
larabr
added a commit
that referenced
this pull request
Oct 25, 2023
Determine whether AEAD should be used for encryption solely based the encryption key preferences. Previously, the config flag was also used to control the behaviour, since AEAD messages were not standardised nor widely supported. To generate keys that declare AEAD in their preferences, use `generateKey` with `config.aeadProtect = true`.
larabr
added a commit
that referenced
this pull request
Apr 19, 2024
…Protect` The logic was updated in github.com//pull/1678 . The affected tests were still successful thanks to the default config.
larabr
added a commit
that referenced
this pull request
May 2, 2024
…Protect` The logic was updated in github.com//pull/1678 . The tests worked anyway thanks to the config option matching the (monkey patched) keys' feature flags, which are the deciding factor for whether to use AEAD.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Determine whether AEAD should be used for encryption solely based the encryption key preferences.
Previously, the config flag was also used to control the behaviour, since AEAD messages were not standardised nor widely supported.
To generate keys that declare AEAD in their preferences, use
generateKeywithconfig.aeadProtect = true.