Add support for verifying User Attributes in verifyAllUsers#1637
Merged
twiss merged 8 commits intoopenpgpjs:mainfrom May 15, 2023
Merged
Conversation
twiss
reviewed
Apr 27, 2023
Member
twiss
left a comment
twiss
left a comment
There was a problem hiding this comment.
Thanks for making a PR! See comments below.
twiss
reviewed
Apr 30, 2023
Member
twiss
left a comment
twiss
left a comment
There was a problem hiding this comment.
Thanks for adding a test case! Some nit picks and further suggestions below.
twiss
reviewed
May 1, 2023
…d-checks-in-verifyallusers
twiss
changed the title
verifyAllUsers
twiss
force-pushed
the
issue-1636-add-user-id-checks-in-verifyallusers
branch
from
fa7159f to
ada3057
Compare
twiss
approved these changes
May 15, 2023
Member
|
We've released v5.9.0 with this change 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for verifying user attributes in
verifyAllUsers().Fixes #1636.