Add additionalAllowedPackets config option #1618
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toberndo
force-pushed
the
additional-allowed-packets
branch
from
cb12059 to
67d6784
Compare
twiss
reviewed
Mar 23, 2023
larabr
reviewed
Mar 23, 2023
toberndo
force-pushed
the
additional-allowed-packets
branch
2 times, most recently
from
bcf665b to
ff3f97f
Compare
larabr
reviewed
Mar 27, 2023
toberndo
force-pushed
the
additional-allowed-packets
branch
from
ff3f97f to
f111f0d
Compare
Member
Author
|
Are there any plans for a new v5.x release before going to v6? |
Member
|
Yeah, we can make a release, I'll do so 👍 |
Member
Author
|
@twiss Thanks so much for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the discussion #1617 this pull requests adds a new config option
additionalAllowedPackets.When parsing for example a SEIP packet, currently only the following nested packets are allowed:
LiteralDataPacket, CompressedDataPacket, OnePassSignaturePacket, SignaturePacket.With this new config option we can add additional packet classes to the list of allowed packets.