Add UnparseablePacket to properly deal with key blocks that include malformed/unsupported packets#1522
Merged
larabr merged 4 commits intoopenpgpjs:mainfrom May 24, 2022
Merged
Conversation
…lformed or unsupported packets
twiss
reviewed
May 24, 2022
Member
twiss
left a comment
twiss
left a comment
There was a problem hiding this comment.
Looks good to me, except one nitpick below
larabr
changed the title
UnparsablePacket to properly deal with key blocks that include malformed/unsupported packetsUnparseablePacket to properly deal with key blocks that include malformed/unsupported packets
twiss
approved these changes
May 24, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1420 : when parsing errors are being ignored, packets that fail to parse are now included in the resulting packet list as
UnparseablePackets . This way, when parsing keys that contain unparsable (sub)key, we avoid associating the following non-key packets to the wrong key entity.On serialization,
UnparseablePackets are also included by writing their raw packet body as it was read.