Skip to content

Conversation

@omkarK06
Copy link
Contributor

No description provided.

@github-actions
Copy link
Contributor

Failed to generate code suggestions for PR

@github-actions github-actions bot added the ☢️ Bug Something isn't working label Dec 10, 2025
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Dec 10, 2025

Greptile Overview

Greptile Summary

Added resetPagination() calls to both stream selection handlers (handleMultiStreamSelection and handleSingleStreamSelect) to reset the fields list pagination when the user changes streams.

  • Fixes issue where pagination state persisted after stream changes, showing stale page numbers
  • Consistent with existing pagination reset patterns used in toggleSchema() and toggleInterestingFields()
  • Also exports resetPagination from setup return to make it accessible from methods

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • Simple, focused fix that adds pagination reset calls to stream selection handlers, following existing patterns in the codebase. No logic changes or risky modifications.
  • No files require special attention

Important Files Changed

File Analysis

Filename Score Overview
web/src/plugins/logs/IndexList.vue 5/5 Added resetPagination() calls to stream selection handlers to fix pagination state on stream changes

Sequence Diagram

sequenceDiagram
    participant User
    participant StreamSelect as Stream Select Dropdown
    participant Handler as Selection Handler
    participant Pagination as Pagination State
    participant FieldList as Field List Component
    
    User->>StreamSelect: Select/change stream(s)
    StreamSelect->>Handler: handleMultiStreamSelection() or handleSingleStreamSelect()
    Handler->>Handler: Clear filter input via $nextTick
    Handler->>Handler: Call onStreamChange("")
    Handler->>Pagination: Call resetPagination()
    Pagination->>Pagination: Set page to 1
    Pagination->>FieldList: Scroll to top via nextTick
    FieldList-->>User: Display fields from page 1
Loading

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No files reviewed, no comments

Edit Code Review Agent Settings | Greptile

@omkarK06 omkarK06 merged commit 4b01421 into branch-v0.30.0 Dec 10, 2025
38 checks passed
@omkarK06 omkarK06 deleted the fix/reset-field-list-pagination-v0.30.0 branch December 10, 2025 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

☢️ Bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants