Failed to generate code suggestions for PR

Greptile Overview

Greptile Summary

Centralizes highlight query management by storing it in searchObj.data.highlightQuery, replacing duplicated inline query parsing logic in SearchResult.vue.

Key Changes:

• Added highlightQuery field to SearchObjectData interface
• Reset and update highlightQuery in useSearchQuery.getQueryReq() on each query execution
• Replaced inline query parsing (searchObj.data.query.toLowerCase().split('where')[1]) with centralized searchObj.data.highlightQuery in both logs table and detail sidebar

Issues Found:

• highlightQuery is missing from DEFAULT_LOGS_CONFIG constant in constants.ts, causing it to be undefined until the first query runs

Confidence Score: 3/5

• This PR is safe to merge with one logical issue that needs to be addressed
• The approach of centralizing highlight query management is sound and reduces code duplication. However, the highlightQuery field is not initialized in DEFAULT_LOGS_CONFIG, which will cause it to be undefined until the first query executes. This could lead to highlighting not working correctly on initial page load or after state reset.
• web/src/composables/useLogs/searchState.ts requires the addition of highlightQuery to DEFAULT_LOGS_CONFIG in constants.ts

Important Files Changed

File Analysis

Sequence Diagram

sequenceDiagram
    participant User
    participant SearchResult
    participant useSearchQuery
    participant searchState
    participant LogsTable
    participant DetailTable

    User->>SearchResult: Run query
    SearchResult->>useSearchQuery: getQueryReq()
    useSearchQuery->>searchState: Reset highlightQuery to ""
    searchState-->>useSearchQuery: highlightQuery = ""
    useSearchQuery->>useSearchQuery: buildSearch()
    useSearchQuery->>useSearchQuery: Check sqlMode
    alt SQL Mode
        useSearchQuery->>searchState: Set highlightQuery = query.toLowerCase().split("where")[1]
    else Non-SQL Mode
        useSearchQuery->>searchState: Set highlightQuery = query.toLowerCase()
    end
    searchState-->>useSearchQuery: highlightQuery updated
    useSearchQuery-->>SearchResult: Query executed
    SearchResult->>LogsTable: Pass highlightQuery prop
    LogsTable-->>LogsTable: Highlight matching terms
    User->>SearchResult: Click log row
    SearchResult->>DetailTable: Show detail dialog
    SearchResult->>DetailTable: Pass same highlightQuery prop
    DetailTable-->>DetailTable: Highlight matching terms consistently