Skip to content

Conversation

@nikhilsaikethe
Copy link
Contributor

  1. This PR fixes 2 issues
  2. user should have org identifier in the URL when navigating to about section
  3. we should not call license based on feature flag

@github-actions github-actions bot added the ☢️ Bug Something isn't working label Dec 10, 2025
@github-actions
Copy link
Contributor

Failed to generate code suggestions for PR

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Dec 10, 2025

Greptile Overview

Greptile Summary

This PR fixes navigation to the About page to include the org_identifier query parameter and refines the license data loading logic.

  • Changed About menu item from direct router link to event-based navigation, matching the pattern used by Home navigation
  • Added goToAbout handler in MainLayout.vue that includes org_identifier in the route query params
  • Updated license data loading condition to only call the license API for enterprise self-hosted instances (isCloud == 'false' && isEnterprise == 'true'), preventing unnecessary API calls for cloud and non-enterprise installations

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • The changes follow established patterns in the codebase (mirroring goToHome implementation), correctly scope the license API call to enterprise self-hosted instances only, and make straightforward routing improvements without introducing breaking changes or logical errors
  • No files require special attention

Important Files Changed

File Analysis

Filename Score Overview
web/src/components/Header.vue 5/5 Changed about link from router navigation to event emission, following same pattern as goToHome
web/src/layouts/MainLayout.vue 5/5 Added goToAbout handler that navigates to about page with org_identifier query parameter
web/src/views/About.vue 5/5 Refined license data loading condition to only load for enterprise self-hosted instances

Sequence Diagram

sequenceDiagram
    participant User
    participant Header
    participant MainLayout
    participant Router
    participant About

    User->>Header: Click "About" menu item
    Header->>MainLayout: emit("goToAbout")
    MainLayout->>MainLayout: Get org_identifier from store
    MainLayout->>Router: push("/about", {org_identifier})
    Router->>About: Navigate to About page
    About->>About: onMounted()
    alt isCloud == 'false' && isEnterprise == 'true'
        About->>About: loadLicenseData()
    else
        About->>About: Skip license call
    end
Loading

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

@nikhilsaikethe nikhilsaikethe merged commit 1717101 into branch-v0.30.0 Dec 10, 2025
19 checks passed
@nikhilsaikethe nikhilsaikethe deleted the fix/issue-user-logout-about-0.30 branch December 10, 2025 06:47
nikhilsaikethe added a commit that referenced this pull request Dec 11, 2025
1. This PR fixes 2 issues 
2. user should have org identifier in the URL when navigating to about
section
3. we should not call license based on feature flag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

☢️ Bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants