Skip to content

Conversation

@omkarK06
Copy link
Contributor

No description provided.

@omkarK06 omkarK06 changed the base branch from main to branch-v0.30.0 December 10, 2025 06:21
@github-actions github-actions bot added ☢️ Bug Something isn't working ✏️ Feature labels Dec 10, 2025
@github-actions
Copy link
Contributor

Failed to generate code suggestions for PR

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Dec 10, 2025

Greptile Overview

Greptile Summary

Added loading spinner visual feedback to run query and refresh buttons across logs, metrics, traces, and dashboards by binding the :loading prop to existing loading state variables.

  • Logs (web/src/plugins/logs/SearchBar.vue): Run query button now shows spinner when searchObj.loading or searchObj.loadingHistogram is true
  • Metrics (web/src/plugins/metrics/Index.vue): Run query button displays spinner using the disable reactive variable
  • Traces (web/src/plugins/traces/SearchBar.vue): Run query button shows spinner using the isLoading prop
  • Dashboards (web/src/views/Dashboards/ViewDashboard.vue): Refresh button displays spinner when arePanelsLoading is true

All changes reuse existing loading state variables that were already controlling the :disable prop, ensuring consistency between disabled and loading states.

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • The changes are straightforward UI improvements that add loading spinners to buttons. All changes reuse existing, well-tested loading state variables that already control the disable state. No logic changes, no new state introduced, and the modifications are consistent across all four files.
  • No files require special attention

Important Files Changed

File Analysis

Filename Score Overview
web/src/plugins/logs/SearchBar.vue 5/5 Added :loading prop to run query button to display loading spinner when searchObj.loading or searchObj.loadingHistogram is true
web/src/plugins/metrics/Index.vue 5/5 Added :loading and :disable props to run query button using the disable reactive variable
web/src/plugins/traces/SearchBar.vue 5/5 Added :loading prop to run query button using the isLoading prop value
web/src/views/Dashboards/ViewDashboard.vue 5/5 Added :loading prop to dashboard refresh button using the arePanelsLoading reactive variable

Sequence Diagram

sequenceDiagram
    participant User
    participant Button as Run Query Button
    participant State as Loading State
    participant API as Backend API
    
    User->>Button: Click Run Query
    Button->>State: Set loading = true
    Note over Button: Button shows spinner<br/>and becomes disabled
    State->>API: Execute query
    API-->>State: Return results
    State->>Button: Set loading = false
    Note over Button: Spinner disappears<br/>button becomes enabled
    Button-->>User: Display results
Loading

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

@omkarK06 omkarK06 force-pushed the fix/add-search-loader-v0.30.0 branch from 66d52fa to a9f9ade Compare December 10, 2025 09:15
@omkarK06 omkarK06 force-pushed the fix/add-search-loader-v0.30.0 branch from a9f9ade to 1ce2162 Compare December 10, 2025 09:19
@omkarK06 omkarK06 merged commit 5cf4db5 into branch-v0.30.0 Dec 10, 2025
34 checks passed
@omkarK06 omkarK06 deleted the fix/add-search-loader-v0.30.0 branch December 10, 2025 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

☢️ Bug Something isn't working ✏️ Feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants