fix: hide management and insights in alert list #9554
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Failed to generate code suggestions for PR |
Contributor
Greptile OverviewGreptile SummaryHides the "Alert Insights" and "Settings" buttons in the alert list using hardcoded
Confidence Score: 3/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant User
participant AlertList
participant Router
User->>AlertList: View alert list page
Note over AlertList: Alert Insights button hidden (v-if="false")
Note over AlertList: Settings button hidden (v-if="false")
AlertList-->>User: Display alert list with Import and Add buttons only
Note over AlertList,Router: Previously available flows (now hidden):
User->>AlertList: Click Alert Insights (hidden)
AlertList->>Router: Navigate to alertInsights route
User->>AlertList: Click Settings (hidden)
AlertList->>AlertList: Open correlation drawer
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| </div> | ||
| </div> | ||
| <q-btn | ||
| v-if="false" |
Contributor
There was a problem hiding this comment.
style: hardcoded v-if="false" makes this dead code. if hiding a feature temporarily, use a proper feature flag like config.isEnterprise == 'true' (see other parts of codebase). if permanently removing, delete the button entirely instead of leaving dead code
Prompt To Fix With AI
This is a comment left during a code review.
Path: web/src/components/alerts/AlertList.vue
Line: 79:79
Comment:
**style:** hardcoded `v-if="false"` makes this dead code. if hiding a feature temporarily, use a proper feature flag like `config.isEnterprise == 'true'` (see other parts of codebase). if permanently removing, delete the button entirely instead of leaving dead code
How can I resolve this? If you propose a fix, please make it concise.| icon="insights" | ||
| /> | ||
| <q-btn | ||
| v-if="false" |
Contributor
There was a problem hiding this comment.
style: same issue - hardcoded v-if="false" creates dead code. use feature flags or delete entirely
Prompt To Fix With AI
This is a comment left during a code review.
Path: web/src/components/alerts/AlertList.vue
Line: 89:89
Comment:
**style:** same issue - hardcoded `v-if="false"` creates dead code. use feature flags or delete entirely
How can I resolve this? If you propose a fix, please make it concise.
nikhilsaikethe
added a commit
that referenced
this pull request
Dec 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.