-
Notifications
You must be signed in to change notification settings - Fork 715
fix: pipeline condition UI fix #9548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Failed to generate code suggestions for PR |
bjp232004
approved these changes
Dec 10, 2025
Contributor
Greptile OverviewGreptile SummaryThis PR fixes several issues with the pipeline condition UI:
Confidence Score: 4/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant User
participant ConditionForm as Condition.vue
participant FilterGroup
participant FilterCondition
participant PipelineObj as pipelineObj
User->>ConditionForm: Opens condition editor
ConditionForm->>PipelineObj: getDefaultConditionGroup()
PipelineObj-->>ConditionForm: conditions (deep copy)
ConditionForm->>ConditionForm: Store original in originalConditionGroup
User->>FilterGroup: Edits conditions
FilterGroup->>FilterCondition: Passes allowCustomColumns=true
FilterCondition-->>User: Shows column selector with custom value mode
alt User clicks Cancel (X button)
User->>ConditionForm: openCancelDialog()
ConditionForm->>ConditionForm: Compare original vs current
alt Changes detected
ConditionForm-->>User: Show confirmation dialog
User->>ConditionForm: Confirms discard
ConditionForm->>ConditionForm: Restore originalConditionGroup
end
ConditionForm->>PipelineObj: emit("cancel:hideform")
else User clicks Save
User->>ConditionForm: saveCondition()
ConditionForm->>PipelineObj: addNode(conditionData)
ConditionForm->>ConditionForm: Update originalConditionGroup
ConditionForm->>PipelineObj: emit("cancel:hideform")
end
|
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
5 files reviewed, no comments
nikhilsaikethe
added a commit
that referenced
this pull request
Dec 11, 2025
Co-authored-by: Shrinath Rao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.