Skip to content

Conversation

@uddhavdave
Copy link
Contributor

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2025

Failed to generate code suggestions for PR

@github-actions github-actions bot added the ☢️ Bug Something isn't working label Dec 9, 2025
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Dec 9, 2025

Greptile Overview

Greptile Summary

Hides the regex patterns column in the stream settings schema table for OSS builds by adding config.isEnterprise == 'true' checks. The changes ensure that:

  • The "patterns" column is only included in the table columns array for enterprise builds using spread operator conditional logic
  • The patterns cell template only renders interactive content (pattern counts and "Add Pattern" link) for enterprise builds
  • OSS builds display an empty cell instead of the patterns functionality

This prevents OSS users from seeing enterprise-only features in the stream settings UI.

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • The changes are straightforward UI conditional rendering using a well-established pattern (config.isEnterprise == 'true') that's consistently used throughout the codebase. The implementation correctly hides both the column definition and the cell template content, ensuring no functionality leaks to OSS builds.
  • No files require special attention

Important Files Changed

File Analysis

Filename Score Overview
web/src/components/logstream/schema.vue 5/5 Conditionally hides patterns column and cells in stream settings for OSS builds using config.isEnterprise check

Sequence Diagram

sequenceDiagram
    participant User
    participant SchemaVue as Schema.vue
    participant Config as config (aws-exports)
    participant QTable as Quasar Table
    
    User->>SchemaVue: View stream settings
    SchemaVue->>Config: Check config.isEnterprise
    Config-->>SchemaVue: Returns 'true' or 'false'
    
    alt Enterprise Build (isEnterprise == 'true')
        SchemaVue->>QTable: Include patterns column in columns array
        SchemaVue->>QTable: Render patterns cell with pattern data
        QTable-->>User: Show patterns column with clickable cells
    else OSS Build (isEnterprise != 'true')
        SchemaVue->>QTable: Exclude patterns column from columns array
        SchemaVue->>QTable: Render empty cell for patterns slot
        QTable-->>User: Hide patterns column
    end
Loading

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

@uddhavdave uddhavdave merged commit e0ca0b9 into branch-v0.30.0 Dec 9, 2025
38 checks passed
@uddhavdave uddhavdave deleted the ud/fix-sdr-stream-settings branch December 9, 2025 13:49
@uddhavdave uddhavdave added this to the v0.30.0 milestone Dec 10, 2025
@uddhavdave uddhavdave added the Needs-Testing Needs-Testing label Dec 10, 2025
@priyabrata-stack priyabrata-stack added Testing-Completed Testing-Completed and removed Needs-Testing Needs-Testing labels Dec 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

☢️ Bug Something isn't working Testing-Completed Testing-Completed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants