-
Notifications
You must be signed in to change notification settings - Fork 713
fix: cancel query only on enterprise #9535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Failed to generate code suggestions for PR |
Greptile OverviewGreptile SummaryThis PR fixes an error that occurred when canceling queries on non-enterprise deployments. The backend
Confidence Score: 5/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant User
participant LogsComponent as Logs Index.vue
participant CancelQuery as cancelQuery()
participant Backend as /api/{org}/query_manager/cancel
User->>LogsComponent: Navigate away from logs page
LogsComponent->>LogsComponent: onBeforeUnmount triggered
alt Enterprise Edition
LogsComponent->>CancelQuery: cancelQuery()
CancelQuery->>Backend: PUT request with trace IDs
Backend-->>CancelQuery: Success response
CancelQuery-->>LogsComponent: Query cancelled
else Non-Enterprise Edition (after this fix)
LogsComponent->>LogsComponent: Skip cancelQuery() call
Note over LogsComponent: No API call made
end
LogsComponent->>LogsComponent: Continue unmount cleanup
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No files reviewed, no comments
d38638c to
ac818b4
Compare
801d4a7 to
34652a1
Compare
This PR fixes the issue that error while canceling query
This PR fixes the issue that error while canceling query