fix: temp disable datafusion topk optimizer[branch-30] #9520
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haohuaijin
requested review from
Copilot and
hengfeiyang
and removed request for
Copilot
Contributor
|
Failed to generate code suggestions for PR |
hengfeiyang
approved these changes
Dec 9, 2025
Contributor
Greptile OverviewGreptile SummaryDisabled DataFusion's top-k aggregation optimizer by setting
Confidence Score: 5/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant Caller
participant create_session_config
participant SessionConfig
participant DataFusion
Caller->>create_session_config: create_session_config(sorted_by_time, target_partitions)
create_session_config->>SessionConfig: Initialize with defaults
SessionConfig-->>create_session_config: config object
create_session_config->>SessionConfig: Set batch_size, target_partitions, dialect
create_session_config->>SessionConfig: Configure bloom_filter settings
alt sorted_by_time == true
create_session_config->>SessionConfig: Enable split_file_groups_by_statistics
end
Note over create_session_config,SessionConfig: New change in this PR
create_session_config->>SessionConfig: set_bool("enable_topk_aggregation", false)
Note over create_session_config,SessionConfig: Workaround for DataFusion issue #19219
create_session_config->>SessionConfig: Enable skip_physical_aggregate_schema_check
create_session_config-->>Caller: Return configured SessionConfig
Caller->>DataFusion: Use config for query execution
DataFusion-->>Caller: Execute queries with topk optimization disabled
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Shrinath-O2
added
Testing-Completed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a datafusion bug will cause the query error:
abc's data type is string