Skip to content

Conversation

@nikhilsaikethe
Copy link
Contributor

THis PR fixes the issue in #9493

@github-actions github-actions bot added the ☢️ Bug Something isn't working label Dec 5, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2025

Failed to generate code suggestions for PR

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Dec 5, 2025

Greptile Overview

Greptile Summary

This PR changes the license status display logic in both License.vue and About.vue to use the expired field instead of the license.active field, as per issue #9493.

Key changes:

  • Status now shows "Expired" (red badge) when licenseData.expired is true, and "Active" (green badge) when false
  • Removed redundant "Expired" badge from the "Expires At" row since status is now clearly shown in the Status row
  • Label changed from "Active" (Yes/No) to "Status" (Active/Expired) in License.vue

Issue found:

  • The checkAndAutoFillLicenseFromUrl function in License.vue still uses license.active to determine if a license is active, which is inconsistent with the PR's goal of using only the expired field

Confidence Score: 4/5

  • This PR is mostly safe to merge but has one logic inconsistency that should be addressed for complete alignment with the stated goal.
  • Simple UI logic changes with clear intent. One inconsistency found where license.active is still used in the auto-fill dialog logic, which contradicts the PR's goal of only using the expired field.
  • web/src/components/settings/License.vue - line 398 still uses license.active instead of expired

Important Files Changed

File Analysis

Filename Score Overview
web/src/components/settings/License.vue 4/5 Changed status display from license.active to licenseData.expired, simplified expiry date display by removing redundant "Expired" badge. One inconsistency: checkAndAutoFillLicenseFromUrl still uses license.active instead of expired.
web/src/views/About.vue 5/5 Changed status display from license.active to licenseData.expired, simplified "Expires At" row by removing redundant "Expired" badge.

Sequence Diagram

sequenceDiagram
    participant User
    participant License.vue
    participant About.vue
    participant API as License API
    
    User->>License.vue: View License Page
    License.vue->>API: get_license()
    API-->>License.vue: licenseData (includes expired field)
    
    alt licenseData.expired == true
        License.vue->>User: Show "Expired" (red badge)
    else licenseData.expired == false
        License.vue->>User: Show "Active" (green badge)
    end
    
    User->>About.vue: View About Page
    About.vue->>API: get_license()
    API-->>About.vue: licenseData (includes expired field)
    
    alt licenseData.expired == true
        About.vue->>User: Show "Expired" (red badge)
    else licenseData.expired == false
        About.vue->>User: Show "Active" (green badge)
    end
Loading

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional Comments (1)

  1. web/src/components/settings/License.vue, line 398 (link)

    logic: Inconsistency: This still uses licenseData.value.license.active while the rest of the PR switches to using licenseData.value.expired. Per the issue description, the active field should not be considered. Consider changing this to !licenseData.value.expired for consistency.

2 files reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

@nikhilsaikethe nikhilsaikethe merged commit 6f94055 into branch-v0.20.0 Dec 5, 2025
17 of 18 checks passed
@nikhilsaikethe nikhilsaikethe deleted the fix/issue-9493-main branch December 5, 2025 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

☢️ Bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants