-
Notifications
You must be signed in to change notification settings - Fork 715
fix: issue 9455 #9473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
fix: issue 9455 #9473
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fc742db to
2afbc14
Compare
Contributor
|
Failed to generate code suggestions for PR |
bjp232004
approved these changes
Dec 4, 2025
Contributor
Greptile OverviewGreptile SummaryThis PR addresses issue #9455 by adding validation checks in the logs search bar download functionality:
Issues to address:
Confidence Score: 3/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant User
participant SearchBar
participant searchService
participant Notification
Note over User,Notification: Download Flow with New Validations
User->>SearchBar: Click Download (CSV/JSON)
SearchBar->>SearchBar: downloadLogs(data, format)
alt data is empty or null
SearchBar->>Notification: "No data found to download"
Notification-->>User: Show notification
else data exists
SearchBar->>SearchBar: Convert to CSV/JSON
SearchBar-->>User: Download file
end
User->>SearchBar: Click Custom Range Download
SearchBar->>SearchBar: downloadRangeData()
alt customDownloadQueryObj.query missing
SearchBar->>Notification: "Please run a query first"
Notification-->>User: Show notification
else query exists
SearchBar->>searchService: search(query)
searchService-->>SearchBar: results
alt results.hits.length > 0
SearchBar->>SearchBar: downloadLogs(hits, format)
else no hits
SearchBar->>Notification: "No data found to download"
end
end
User->>SearchBar: Schedule Job
SearchBar->>SearchBar: addJobScheduler()
alt no stream selected
SearchBar->>Notification: "Please select a stream"
Notification-->>User: Show notification
else stream selected
SearchBar->>SearchBar: proceed with scheduling
end
|
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No files reviewed, 2 comments
c726c1e to
55b45cd
Compare
55b45cd to
1e34c07
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr fixes the issue in #9455 , stream should be selected before creating scheduled job