-
Notifications
You must be signed in to change notification settings - Fork 715
fix: issue 9354 #9468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
fix: issue 9354 #9468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2e9592d to
c894e8b
Compare
Contributor
|
Failed to generate code suggestions for PR |
Contributor
Greptile OverviewGreptile SummaryImplements auto-suggestion popup for FTS and secondary index fields when enabling User-Defined Schema (UDS) for the first time, helping users avoid performance issues.
Issues found:
Confidence Score: 3/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant User
participant SchemaComponent
participant Dialog as Performance Fields Dialog
participant Store as Vuex Store
User->>SchemaComponent: Select fields to add to UDS
SchemaComponent->>SchemaComponent: updateDefinedSchemaFields()
alt UDS max limit exceeded
SchemaComponent->>User: Show error notification
else UDS is empty (first time)
SchemaComponent->>SchemaComponent: getMissingPerformanceFields()
SchemaComponent->>Store: Get default_fts_keys
SchemaComponent->>Store: Get default_secondary_index_fields
SchemaComponent->>SchemaComponent: Check schema for FTS fields
SchemaComponent->>SchemaComponent: Check schema for Secondary Index fields
alt Missing performance fields found
SchemaComponent->>Dialog: Show popup with missing fields
Dialog->>User: Display FTS and Secondary Index fields
alt User clicks "Add Fields"
User->>Dialog: Click "Add Fields"
Dialog->>SchemaComponent: addPerformanceFields()
SchemaComponent->>SchemaComponent: Combine pending + missing fields
SchemaComponent->>SchemaComponent: proceedWithAddingFields()
SchemaComponent->>SchemaComponent: Update defined_schema_fields
SchemaComponent->>User: Fields added to UDS
else User clicks "Skip"
User->>Dialog: Click "Skip"
Dialog->>SchemaComponent: skipPerformanceFields()
SchemaComponent->>SchemaComponent: proceedWithAddingFields()
SchemaComponent->>SchemaComponent: Update with pending fields only
SchemaComponent->>User: Fields added without performance fields
end
else No missing fields
SchemaComponent->>SchemaComponent: Add fields directly
SchemaComponent->>User: Fields added to UDS
end
else UDS already has fields
SchemaComponent->>SchemaComponent: Add fields directly
SchemaComponent->>User: Fields added to UDS
end
|
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 files reviewed, 2 comments
1cdd74c to
55824cd
Compare
bjp232004
approved these changes
Dec 4, 2025
55824cd to
9fb605d
Compare
ba85966 to
39a1d80
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue in #9354